fbdev: sysfs files can't disappear before the device is gone

Which means lock_fb_info can never fail. Remove the error handling.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Rob Clark <robdclark@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190528090304.9388-14-daniel.vetter@ffwll.ch

diff --git a/drivers/video/fbdev/core/fbsysfs.c b/drivers/video/fbdev/core/fbsysfs.c
index 954ed99e80dac25fd82d8412071c17762e31508b..f80d5b3a7797f152eb7ccd2880b739f81a83d239 100644 (file)
--- a/drivers/video/fbdev/core/fbsysfs.c
+++ b/drivers/video/fbdev/core/fbsysfs.c
@@ -175,10 +175,7 @@ static ssize_t store_modes(struct device *device,
                return -EINVAL;
 
        console_lock();
-       if (!lock_fb_info(fb_info)) {
-               console_unlock();
-               return -ENODEV;
-       }
+       lock_fb_info(fb_info);
 
        list_splice(&fb_info->modelist, &old_list);
        fb_videomode_to_modelist((const struct fb_videomode *)buf, i,
@@ -405,10 +402,7 @@ static ssize_t store_fbstate(struct device *device,
        state = simple_strtoul(buf, &last, 0);
 
        console_lock();
-       if (!lock_fb_info(fb_info)) {
-               console_unlock();
-               return -ENODEV;
-       }
+       lock_fb_info(fb_info);
 
        fb_set_suspend(fb_info, (int)state);