staging: rtl8188eu: rtw_set_fixed_ie(): accept void* parameters
authorLuca Ceresoli <luca@lucaceresoli.net>
Tue, 22 Sep 2015 21:50:36 +0000 (23:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Sep 2015 02:27:22 +0000 (04:27 +0200)
rtw_set_ie() is a memcpy-like function, taking addresses of memory buffers
among its parameters. Similarly to memcpy, change the parameters to be
void*. This will allow to get rid of typecasts whenever it is called.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_ieee80211.c
drivers/staging/rtl8188eu/include/ieee80211.h

index c3c582881a091e5294376e3436546e27ee5ed604..39325a3a2fa2649ed1a7eb757a551fb650d9cc86 100644 (file)
@@ -130,12 +130,12 @@ int rtw_check_network_type(unsigned char *rate, int ratelen, int channel)
        }
 }
 
-u8 *rtw_set_fixed_ie(unsigned char *pbuf, unsigned int len, unsigned char *source,
-                               unsigned int *frlen)
+u8 *rtw_set_fixed_ie(void *pbuf, unsigned int len, void *source,
+                    unsigned int *frlen)
 {
-       memcpy((void *)pbuf, (void *)source, len);
+       memcpy(pbuf, source, len);
        *frlen = *frlen + len;
-       return pbuf + len;
+       return ((u8 *)pbuf) + len;
 }
 
 /*  rtw_set_ie will update frame length */
index 6400f75707bd54a2ba7ba40277b1364afe8afb0c..f8f5eb6b79769995c29ee1323f07a4e33290142d 100644 (file)
@@ -1092,8 +1092,8 @@ enum parse_res rtw_ieee802_11_parse_elems(u8 *start, uint len,
                                          struct rtw_ieee802_11_elems *elems,
                                          int show_errors);
 
-u8 *rtw_set_fixed_ie(unsigned char *pbuf, unsigned int len,
-                    unsigned char *source, unsigned int *frlen);
+u8 *rtw_set_fixed_ie(void *pbuf, unsigned int len,
+                    void *source, unsigned int *frlen);
 u8 *rtw_set_ie(u8 *pbuf, int index, uint len, u8 *source, uint *frlen);
 
 enum secondary_ch_offset {