udmabuf: use sizeof(variable) instead of sizeof(type)
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 11 Sep 2018 13:42:15 +0000 (15:42 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 12 Sep 2018 06:21:33 +0000 (08:21 +0200)
Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20180911134216.9760-13-kraxel@redhat.com
drivers/dma-buf/udmabuf.c

index 63cc77edd1f32aa2c6eb379514b524dcbf650024..9edabce0b8ab3c82e0f91d43415881904d4592c3 100644 (file)
@@ -128,7 +128,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
        int seals, ret = -EINVAL;
        u32 i, flags;
 
-       ubuf = kzalloc(sizeof(struct udmabuf), GFP_KERNEL);
+       ubuf = kzalloc(sizeof(*ubuf), GFP_KERNEL);
        if (!ubuf)
                return -ENOMEM;
 
@@ -142,7 +142,7 @@ static long udmabuf_create(const struct udmabuf_create_list *head,
                if (ubuf->pagecount > pglimit)
                        goto err;
        }
-       ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(struct page *),
+       ubuf->pages = kmalloc_array(ubuf->pagecount, sizeof(*ubuf->pages),
                                    GFP_KERNEL);
        if (!ubuf->pages) {
                ret = -ENOMEM;
@@ -211,7 +211,7 @@ static long udmabuf_ioctl_create(struct file *filp, unsigned long arg)
        struct udmabuf_create_item list;
 
        if (copy_from_user(&create, (void __user *)arg,
-                          sizeof(struct udmabuf_create)))
+                          sizeof(create)))
                return -EFAULT;
 
        head.flags  = create.flags;