drm: Change create block to reserve node

With the previous patch we no longer actually create a node, we simply
find the correct hole and occupy it. This very well could have been
squashed with the last patch, but since I already had David's review, I
figured it's easiest to keep it distinct.

Also update the users in i915. Conveniently this is the only user of the
interface.

CC: David Airlie <airlied@linux.ie>
CC: <dri-devel@lists.freedesktop.org>
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Acked-by: David Airlie <airlied@linux.ie>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 9e8dfbc1955e2c3818b49b119878099e9f2afcfa..52e0ee7f4a6f0c00b79c6b9a29a4f04cd7e64e44 100644 (file)
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -147,27 +147,27 @@ static void drm_mm_insert_helper(struct drm_mm_node *hole_node,
        }
 }
 
-int drm_mm_create_block(struct drm_mm *mm, struct drm_mm_node *node,
-                       unsigned long start, unsigned long size)
+int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
 {
        struct drm_mm_node *hole;
-       unsigned long end = start + size;
+       unsigned long end = node->start + node->size;
        unsigned long hole_start;
        unsigned long hole_end;
 
+       BUG_ON(node == NULL);
+
+       /* Find the relevant hole to add our node to */
        drm_mm_for_each_hole(hole, mm, hole_start, hole_end) {
-               if (hole_start > start || hole_end < end)
+               if (hole_start > node->start || hole_end < end)
                        continue;
 
-               node->start = start;
-               node->size = size;
                node->mm = mm;
                node->allocated = 1;
 
                INIT_LIST_HEAD(&node->hole_stack);
                list_add(&node->node_list, &hole->node_list);
 
-               if (start == hole_start) {
+               if (node->start == hole_start) {
                        hole->hole_follows = 0;
                        list_del_init(&hole->hole_stack);
                }
@@ -181,10 +181,11 @@ int drm_mm_create_block(struct drm_mm *mm, struct drm_mm_node *node,
                return 0;
        }
 
-       WARN(1, "no hole found for block 0x%lx + 0x%lx\n", start, size);
+       WARN(1, "no hole found for node 0x%lx + 0x%lx\n",
+            node->start, node->size);
        return -ENOSPC;
 }
-EXPORT_SYMBOL(drm_mm_create_block);
+EXPORT_SYMBOL(drm_mm_reserve_node);
 
 struct drm_mm_node *drm_mm_get_block_generic(struct drm_mm_node *hole_node,
                                             unsigned long size,

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 88180a597c0a7c0399582a3fd013f312b7692aa3..afba7e5e7739e6628b04eb82a0010ae09eed0ecf 100644 (file)
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -640,10 +640,10 @@ void i915_gem_setup_global_gtt(struct drm_device *dev,
                                  obj->gtt_offset);
                        continue;
                }
-               ret = drm_mm_create_block(&dev_priv->mm.gtt_space,
-                                         obj->gtt_space,
-                                         obj->gtt_offset,
-                                         obj->base.size);
+               obj->gtt_space->start = obj->gtt_offset;
+               obj->gtt_space->size = obj->base.size;
+               ret = drm_mm_reserve_node(&dev_priv->mm.gtt_space,
+                                         obj->gtt_space);
                if (ret) {
                        DRM_DEBUG_KMS("Reservation failed\n");
                        kfree(obj->gtt_space);

diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c
index 2746ff2d846a07048f3d028b3e7a84102719ae44..4e6dbbb47dfe64a5d767bd1246198b79279cc3a5 100644 (file)
--- a/drivers/gpu/drm/i915/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
@@ -349,8 +349,9 @@ i915_gem_object_create_stolen_for_preallocated(struct drm_device *dev,
        if (!stolen)
                return NULL;
 
-       ret = drm_mm_create_block(&dev_priv->mm.stolen, stolen, stolen_offset,
-                                 size);
+       stolen->start = stolen_offset;
+       stolen->size = size;
+       ret = drm_mm_reserve_node(&dev_priv->mm.stolen, stolen);
        if (ret) {
                DRM_DEBUG_KMS("failed to allocate stolen space\n");
                kfree(stolen);
@@ -380,9 +381,10 @@ i915_gem_object_create_stolen_for_preallocated(struct drm_device *dev,
                        goto unref_out;
                }
 
-               ret = drm_mm_create_block(&dev_priv->mm.gtt_space,
-                                         obj->gtt_space,
-                                         gtt_offset, size);
+               obj->gtt_space->start = gtt_offset;
+               obj->gtt_space->size = size;
+               ret = drm_mm_reserve_node(&dev_priv->mm.gtt_space,
+                                         obj->gtt_space);
                if (ret) {
                        DRM_DEBUG_KMS("failed to allocate stolen GTT space\n");
                        goto free_out;

diff --git a/include/drm/drm_mm.h b/include/drm/drm_mm.h
index d8b56b7d183931d022c48641cea7c2676dec3565..2de91e3da5cc723a576776c3027b487f831a88f0 100644 (file)
--- a/include/drm/drm_mm.h
+++ b/include/drm/drm_mm.h
@@ -138,10 +138,7 @@ static inline unsigned long drm_mm_hole_node_end(struct drm_mm_node *hole_node)
 /*
  * Basic range manager support (drm_mm.c)
  */
-extern int drm_mm_create_block(struct drm_mm *mm,
-                              struct drm_mm_node *node,
-                              unsigned long start,
-                              unsigned long size);
+extern int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node);
 extern struct drm_mm_node *drm_mm_get_block_generic(struct drm_mm_node *node,
                                                    unsigned long size,
                                                    unsigned alignment,