USB: serial: mos7840: remove set but not used variables 'st, data1, iflag'
authorYueHaibing <yuehaibing@huawei.com>
Fri, 26 Oct 2018 12:25:49 +0000 (20:25 +0800)
committerJohan Hovold <johan@kernel.org>
Mon, 12 Nov 2018 09:35:14 +0000 (10:35 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/serial/mos7840.c: In function 'mos7840_interrupt_callback':
drivers/usb/serial/mos7840.c:604:14: warning:
 variable 'st' set but not used [-Wunused-but-set-variable]

drivers/usb/serial/mos7840.c: In function 'mos7840_write':
drivers/usb/serial/mos7840.c:1303:17: warning:
 variable 'data1' set but not used [-Wunused-but-set-variable]

drivers/usb/serial/mos7840.c:1700:11: warning:
 variable 'iflag' set but not used [-Wunused-but-set-variable]

They are never used since introduction in commit 3f5429746d91 ("USB:
Moschip 7840 USB-Serial Driver")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c

index 88828b4b8c446126b83455df327ed4f8e36c8a91..bfbf75b36349e86bf4d01064f7d7233c4bde7bdd 100644 (file)
@@ -601,7 +601,7 @@ static void mos7840_interrupt_callback(struct urb *urb)
        struct usb_serial *serial;
        __u16 Data;
        unsigned char *data;
-       __u8 sp[5], st;
+       __u8 sp[5];
        int i, rv = 0;
        __u16 wval, wreg = 0;
        int status = urb->status;
@@ -644,7 +644,6 @@ static void mos7840_interrupt_callback(struct urb *urb)
        sp[1] = (__u8) data[1];
        sp[2] = (__u8) data[2];
        sp[3] = (__u8) data[3];
-       st = (__u8) data[4];
 
        for (i = 0; i < serial->num_ports; i++) {
                mos7840_port = mos7840_get_port_private(serial->port[i]);
@@ -1300,7 +1299,6 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
        struct urb *urb;
        /* __u16 Data; */
        const unsigned char *current_position = data;
-       unsigned char *data1;
 
        if (mos7840_port_paranoia_check(port, __func__))
                return -1;
@@ -1361,7 +1359,6 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port,
                        mos7840_bulk_out_data_callback, mos7840_port);
        }
 
-       data1 = urb->transfer_buffer;
        dev_dbg(&port->dev, "bulkout endpoint is %d\n", port->bulk_out_endpointAddress);
 
        if (mos7840_port->has_led)
@@ -1697,7 +1694,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
 {
        int baud;
        unsigned cflag;
-       unsigned iflag;
        __u8 lData;
        __u8 lParity;
        __u8 lStop;
@@ -1729,7 +1725,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
        lParity = LCR_PAR_NONE;
 
        cflag = tty->termios.c_cflag;
-       iflag = tty->termios.c_iflag;
 
        /* Change the number of bits */
        switch (cflag & CSIZE) {