net: axienet: let core reject the unsupported coalescing parameters
authorJakub Kicinski <kuba@kernel.org>
Mon, 16 Mar 2020 20:47:11 +0000 (13:47 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 18 Mar 2020 03:56:58 +0000 (20:56 -0700)
Set ethtool_ops->supported_coalesce_params to let
the core reject unsupported coalescing parameters.

This driver already correctly rejected all unsupported
parameters. No functional changes.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c

index c2f4c5ca2e80d7a6a3340f875f33e11cdba0bc73..e2f3e2b0cec7e4e923601b642436579ef05cc86c 100644 (file)
@@ -1309,27 +1309,6 @@ static int axienet_ethtools_set_coalesce(struct net_device *ndev,
                return -EFAULT;
        }
 
-       if ((ecoalesce->rx_coalesce_usecs) ||
-           (ecoalesce->rx_coalesce_usecs_irq) ||
-           (ecoalesce->rx_max_coalesced_frames_irq) ||
-           (ecoalesce->tx_coalesce_usecs) ||
-           (ecoalesce->tx_coalesce_usecs_irq) ||
-           (ecoalesce->tx_max_coalesced_frames_irq) ||
-           (ecoalesce->stats_block_coalesce_usecs) ||
-           (ecoalesce->use_adaptive_rx_coalesce) ||
-           (ecoalesce->use_adaptive_tx_coalesce) ||
-           (ecoalesce->pkt_rate_low) ||
-           (ecoalesce->rx_coalesce_usecs_low) ||
-           (ecoalesce->rx_max_coalesced_frames_low) ||
-           (ecoalesce->tx_coalesce_usecs_low) ||
-           (ecoalesce->tx_max_coalesced_frames_low) ||
-           (ecoalesce->pkt_rate_high) ||
-           (ecoalesce->rx_coalesce_usecs_high) ||
-           (ecoalesce->rx_max_coalesced_frames_high) ||
-           (ecoalesce->tx_coalesce_usecs_high) ||
-           (ecoalesce->tx_max_coalesced_frames_high) ||
-           (ecoalesce->rate_sample_interval))
-               return -EOPNOTSUPP;
        if (ecoalesce->rx_max_coalesced_frames)
                lp->coalesce_count_rx = ecoalesce->rx_max_coalesced_frames;
        if (ecoalesce->tx_max_coalesced_frames)
@@ -1357,6 +1336,7 @@ axienet_ethtools_set_link_ksettings(struct net_device *ndev,
 }
 
 static const struct ethtool_ops axienet_ethtool_ops = {
+       .supported_coalesce_params = ETHTOOL_COALESCE_MAX_FRAMES,
        .get_drvinfo    = axienet_ethtools_get_drvinfo,
        .get_regs_len   = axienet_ethtools_get_regs_len,
        .get_regs       = axienet_ethtools_get_regs,