Revert "Input: zforce - don't overwrite the stack"
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 28 Jul 2015 17:25:03 +0000 (10:25 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 28 Jul 2015 17:25:03 +0000 (10:25 -0700)
This reverts commit 7d01cd261c76f95913c81554a751968a1d282d3a because
with given FRAME_MAXSIZE of 257 the check will never trigger and it
causes warnings from GCC (with -Wtype-limits). Also the check was
incorrect as it was not accounting for the already read 2 bytes of data
stored in the buffer.

drivers/input/touchscreen/zforce_ts.c

index 80285c71786ee58a85d268adb20ad283a1fd54a9..f58a196521a9a99fc3d4838b86db7aba4b7aca02 100644 (file)
@@ -429,7 +429,7 @@ static int zforce_read_packet(struct zforce_ts *ts, u8 *buf)
                goto unlock;
        }
 
-       if (buf[PAYLOAD_LENGTH] == 0 || buf[PAYLOAD_LENGTH] > FRAME_MAXSIZE) {
+       if (buf[PAYLOAD_LENGTH] == 0) {
                dev_err(&client->dev, "invalid payload length: %d\n",
                        buf[PAYLOAD_LENGTH]);
                ret = -EIO;