ipv4: fix rcu lock imbalance in fib_select_default()
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 14 Feb 2011 19:23:04 +0000 (11:23 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Feb 2011 19:23:04 +0000 (11:23 -0800)
Commit 0c838ff1ade7 (ipv4: Consolidate all default route selection
implementations.) forgot to remove one rcu_read_unlock() from
fib_select_default().

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c

index 146bd82ef60dfc2318490d56f25b1d2e698701c2..562f34cd93033412f9408ad21962a3968e04f17e 100644 (file)
@@ -1189,7 +1189,7 @@ void fib_select_default(struct fib_result *res)
                fib_result_assign(res, last_resort);
        tb->tb_default = last_idx;
 out:
-       rcu_read_unlock();
+       return;
 }
 
 #ifdef CONFIG_IP_ROUTE_MULTIPATH