drm/nouveau/core: add falcon library functions
authorAlexandre Courbot <acourbot@nvidia.com>
Tue, 13 Dec 2016 08:11:19 +0000 (17:11 +0900)
committerBen Skeggs <bskeggs@redhat.com>
Fri, 17 Feb 2017 05:14:30 +0000 (15:14 +1000)
Falcon processors are used in various places of GPU chips. Although there
exist different versions of the falcon, and some variants exist, the
base set of actions performed on them is the same, which results in lots
of duplicated code.

This patch consolidates the current nvkm_falcon structure and extends it
with the following features:

* Ability for an engine to obtain and later release a given falcon,
* Abstractions for basic operations (IMEM/DMEM access, start, etc)
* Abstractions for secure operations if a falcon is secure

Abstractions make it easy to e.g. start a falcon, without having to care
about its details. For instance, falcons in secure mode need to be
started by writing to a different register.

Right now the abstractions variants only cover secure vs. non-secure
falcon, but more will come as e.g. SEC2 support is added.

This is still a WIP as other functions previously done by
engine/falcon.c need to be reimplemented. However this first step allows
to keep things simple and to discuss basic design.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
drivers/gpu/drm/nouveau/include/nvkm/engine/falcon.h
drivers/gpu/drm/nouveau/nvkm/Kbuild
drivers/gpu/drm/nouveau/nvkm/falcon/Kbuild [new file with mode: 0644]
drivers/gpu/drm/nouveau/nvkm/falcon/base.c [new file with mode: 0644]
drivers/gpu/drm/nouveau/nvkm/falcon/priv.h [new file with mode: 0644]
drivers/gpu/drm/nouveau/nvkm/falcon/v1.c [new file with mode: 0644]

index e6baf039c269dfb36c128ae0f60c5a70afc16be9..7e498e65b1e8db8d9b965ed26327d33f6bd2b050 100644 (file)
@@ -4,13 +4,26 @@
 #include <core/engine.h>
 struct nvkm_fifo_chan;
 
+enum nvkm_falcon_dmaidx {
+       FALCON_DMAIDX_UCODE             = 0,
+       FALCON_DMAIDX_VIRT              = 1,
+       FALCON_DMAIDX_PHYS_VID          = 2,
+       FALCON_DMAIDX_PHYS_SYS_COH      = 3,
+       FALCON_DMAIDX_PHYS_SYS_NCOH     = 4,
+};
+
 struct nvkm_falcon {
        const struct nvkm_falcon_func *func;
-       struct nvkm_engine engine;
-
+       const struct nvkm_subdev *owner;
+       const char *name;
        u32 addr;
-       u8  version;
-       u8  secret;
+
+       struct mutex mutex;
+       const struct nvkm_subdev *user;
+
+       u8 version;
+       u8 secret;
+       bool debug;
 
        struct nvkm_memory *core;
        bool external;
@@ -19,15 +32,25 @@ struct nvkm_falcon {
                u32 limit;
                u32 *data;
                u32  size;
+               u8 ports;
        } code;
 
        struct {
                u32 limit;
                u32 *data;
                u32  size;
+               u8 ports;
        } data;
+
+       struct nvkm_engine engine;
 };
 
+int nvkm_falcon_v1_new(struct nvkm_subdev *owner, const char *name, u32 addr,
+                      struct nvkm_falcon **);
+void nvkm_falcon_del(struct nvkm_falcon **);
+int nvkm_falcon_get(struct nvkm_falcon *, const struct nvkm_subdev *);
+void nvkm_falcon_put(struct nvkm_falcon *, const struct nvkm_subdev *);
+
 int nvkm_falcon_new_(const struct nvkm_falcon_func *, struct nvkm_device *,
                     int index, bool enable, u32 addr, struct nvkm_engine **);
 
@@ -42,6 +65,51 @@ struct nvkm_falcon_func {
        } data;
        void (*init)(struct nvkm_falcon *);
        void (*intr)(struct nvkm_falcon *, struct nvkm_fifo_chan *);
+       void (*load_imem)(struct nvkm_falcon *, void *, u32, u32, u16, u8, bool);
+       void (*load_dmem)(struct nvkm_falcon *, void *, u32, u32, u8);
+       void (*read_dmem)(struct nvkm_falcon *, u32, u32, u8, void *);
+       void (*bind_context)(struct nvkm_falcon *, struct nvkm_gpuobj *);
+       int (*wait_for_halt)(struct nvkm_falcon *, u32);
+       int (*clear_interrupt)(struct nvkm_falcon *, u32);
+       void (*set_start_addr)(struct nvkm_falcon *, u32 start_addr);
+       void (*start)(struct nvkm_falcon *);
+       int (*enable)(struct nvkm_falcon *falcon);
+       void (*disable)(struct nvkm_falcon *falcon);
+
        struct nvkm_sclass sclass[];
 };
+
+static inline u32
+nvkm_falcon_rd32(struct nvkm_falcon *falcon, u32 addr)
+{
+       return nvkm_rd32(falcon->owner->device, falcon->addr + addr);
+}
+
+static inline void
+nvkm_falcon_wr32(struct nvkm_falcon *falcon, u32 addr, u32 data)
+{
+       nvkm_wr32(falcon->owner->device, falcon->addr + addr, data);
+}
+
+static inline u32
+nvkm_falcon_mask(struct nvkm_falcon *falcon, u32 addr, u32 mask, u32 val)
+{
+       struct nvkm_device *device = falcon->owner->device;
+
+       return nvkm_mask(device, falcon->addr + addr, mask, val);
+}
+
+void nvkm_falcon_load_imem(struct nvkm_falcon *, void *, u32, u32, u16, u8,
+                          bool);
+void nvkm_falcon_load_dmem(struct nvkm_falcon *, void *, u32, u32, u8);
+void nvkm_falcon_read_dmem(struct nvkm_falcon *, u32, u32, u8, void *);
+void nvkm_falcon_bind_context(struct nvkm_falcon *, struct nvkm_gpuobj *);
+void nvkm_falcon_set_start_addr(struct nvkm_falcon *, u32);
+void nvkm_falcon_start(struct nvkm_falcon *);
+int nvkm_falcon_wait_for_halt(struct nvkm_falcon *, u32);
+int nvkm_falcon_clear_interrupt(struct nvkm_falcon *, u32);
+int nvkm_falcon_enable(struct nvkm_falcon *);
+void nvkm_falcon_disable(struct nvkm_falcon *);
+int nvkm_falcon_reset(struct nvkm_falcon *);
+
 #endif
index 2832147b676c33ea4140194f830699df99292cf4..e664378f6eda38a15ad43c80b701950498a2dabe 100644 (file)
@@ -1,3 +1,4 @@
 include $(src)/nvkm/core/Kbuild
+include $(src)/nvkm/falcon/Kbuild
 include $(src)/nvkm/subdev/Kbuild
 include $(src)/nvkm/engine/Kbuild
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/Kbuild b/drivers/gpu/drm/nouveau/nvkm/falcon/Kbuild
new file mode 100644 (file)
index 0000000..584863d
--- /dev/null
@@ -0,0 +1,2 @@
+nvkm-y += nvkm/falcon/base.o
+nvkm-y += nvkm/falcon/v1.o
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/base.c b/drivers/gpu/drm/nouveau/nvkm/falcon/base.c
new file mode 100644 (file)
index 0000000..4852f31
--- /dev/null
@@ -0,0 +1,191 @@
+/*
+ * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+#include "priv.h"
+
+#include <subdev/mc.h>
+
+void
+nvkm_falcon_load_imem(struct nvkm_falcon *falcon, void *data, u32 start,
+                     u32 size, u16 tag, u8 port, bool secure)
+{
+       if (secure && !falcon->secret) {
+               nvkm_warn(falcon->user,
+                         "writing with secure tag on a non-secure falcon!\n");
+               return;
+       }
+
+       falcon->func->load_imem(falcon, data, start, size, tag, port,
+                               secure);
+}
+
+void
+nvkm_falcon_load_dmem(struct nvkm_falcon *falcon, void *data, u32 start,
+                     u32 size, u8 port)
+{
+       falcon->func->load_dmem(falcon, data, start, size, port);
+}
+
+void
+nvkm_falcon_read_dmem(struct nvkm_falcon *falcon, u32 start, u32 size, u8 port,
+                     void *data)
+{
+       falcon->func->read_dmem(falcon, start, size, port, data);
+}
+
+void
+nvkm_falcon_bind_context(struct nvkm_falcon *falcon, struct nvkm_gpuobj *inst)
+{
+       if (!falcon->func->bind_context) {
+               nvkm_error(falcon->user,
+                          "Context binding not supported on this falcon!\n");
+               return;
+       }
+
+       falcon->func->bind_context(falcon, inst);
+}
+
+void
+nvkm_falcon_set_start_addr(struct nvkm_falcon *falcon, u32 start_addr)
+{
+       falcon->func->set_start_addr(falcon, start_addr);
+}
+
+void
+nvkm_falcon_start(struct nvkm_falcon *falcon)
+{
+       falcon->func->start(falcon);
+}
+
+int
+nvkm_falcon_enable(struct nvkm_falcon *falcon)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       enum nvkm_devidx id = falcon->owner->index;
+       int ret;
+
+       nvkm_mc_enable(device, id);
+       ret = falcon->func->enable(falcon);
+       if (ret) {
+               nvkm_mc_disable(device, id);
+               return ret;
+       }
+
+       return 0;
+}
+
+void
+nvkm_falcon_disable(struct nvkm_falcon *falcon)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       enum nvkm_devidx id = falcon->owner->index;
+
+       /* already disabled, return or wait_idle will timeout */
+       if (!nvkm_mc_enabled(device, id))
+               return;
+
+       falcon->func->disable(falcon);
+
+       nvkm_mc_disable(device, id);
+}
+
+int
+nvkm_falcon_reset(struct nvkm_falcon *falcon)
+{
+       nvkm_falcon_disable(falcon);
+       return nvkm_falcon_enable(falcon);
+}
+
+int
+nvkm_falcon_wait_for_halt(struct nvkm_falcon *falcon, u32 ms)
+{
+       return falcon->func->wait_for_halt(falcon, ms);
+}
+
+int
+nvkm_falcon_clear_interrupt(struct nvkm_falcon *falcon, u32 mask)
+{
+       return falcon->func->clear_interrupt(falcon, mask);
+}
+
+void
+nvkm_falcon_put(struct nvkm_falcon *falcon, const struct nvkm_subdev *user)
+{
+       mutex_lock(&falcon->mutex);
+       if (falcon->user == user) {
+               nvkm_debug(falcon->user, "released %s falcon\n", falcon->name);
+               falcon->user = NULL;
+       }
+       mutex_unlock(&falcon->mutex);
+}
+
+int
+nvkm_falcon_get(struct nvkm_falcon *falcon, const struct nvkm_subdev *user)
+{
+       mutex_lock(&falcon->mutex);
+       if (falcon->user) {
+               nvkm_error(user, "%s falcon already acquired by %s!\n",
+                          falcon->name, nvkm_subdev_name[falcon->user->index]);
+               mutex_unlock(&falcon->mutex);
+               return -EBUSY;
+       }
+
+       nvkm_debug(user, "acquired %s falcon\n", falcon->name);
+       falcon->user = user;
+       mutex_unlock(&falcon->mutex);
+       return 0;
+}
+
+void
+nvkm_falcon_ctor(const struct nvkm_falcon_func *func,
+                struct nvkm_subdev *subdev, const char *name, u32 addr,
+                struct nvkm_falcon *falcon)
+{
+       u32 reg;
+
+       falcon->func = func;
+       falcon->owner = subdev;
+       falcon->name = name;
+       falcon->addr = addr;
+       mutex_init(&falcon->mutex);
+
+       reg = nvkm_falcon_rd32(falcon, 0x12c);
+       falcon->version = reg & 0xf;
+       falcon->secret = (reg >> 4) & 0x3;
+       falcon->code.ports = (reg >> 8) & 0xf;
+       falcon->data.ports = (reg >> 12) & 0xf;
+
+       reg = nvkm_falcon_rd32(falcon, 0x108);
+       falcon->code.limit = (reg & 0x1ff) << 8;
+       falcon->data.limit = (reg & 0x3fe00) >> 1;
+
+       reg = nvkm_falcon_rd32(falcon, 0xc08);
+       falcon->debug = (reg >> 20) & 0x1;
+}
+
+void
+nvkm_falcon_del(struct nvkm_falcon **pfalcon)
+{
+       if (*pfalcon) {
+               kfree(*pfalcon);
+               *pfalcon = NULL;
+       }
+}
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/priv.h b/drivers/gpu/drm/nouveau/nvkm/falcon/priv.h
new file mode 100644 (file)
index 0000000..97b56f7
--- /dev/null
@@ -0,0 +1,8 @@
+#ifndef __NVKM_FALCON_PRIV_H__
+#define __NVKM_FALCON_PRIV_H__
+#include <engine/falcon.h>
+
+void
+nvkm_falcon_ctor(const struct nvkm_falcon_func *, struct nvkm_subdev *,
+                const char *, u32, struct nvkm_falcon *);
+#endif
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/v1.c b/drivers/gpu/drm/nouveau/nvkm/falcon/v1.c
new file mode 100644 (file)
index 0000000..24a2958
--- /dev/null
@@ -0,0 +1,263 @@
+/*
+ * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+#include "priv.h"
+
+#include <core/gpuobj.h>
+#include <core/memory.h>
+#include <subdev/timer.h>
+
+static void
+nvkm_falcon_v1_load_imem(struct nvkm_falcon *falcon, void *data, u32 start,
+                        u32 size, u16 tag, u8 port, bool secure)
+{
+       u8 rem = size % 4;
+       u32 reg;
+       int i;
+
+       size -= rem;
+
+       reg = start | BIT(24) | (secure ? BIT(28) : 0);
+       nvkm_falcon_wr32(falcon, 0x180 + (port * 16), reg);
+       for (i = 0; i < size / 4; i++) {
+               /* write new tag every 256B */
+               if ((i & 0x3f) == 0)
+                       nvkm_falcon_wr32(falcon, 0x188, tag++);
+               nvkm_falcon_wr32(falcon, 0x184, ((u32 *)data)[i]);
+       }
+
+       /*
+        * If size is not a multiple of 4, mask the last work to ensure garbage
+        * does not get written
+        */
+       if (rem) {
+               u32 extra = ((u32 *)data)[i];
+
+               /* write new tag every 256B */
+               if ((i & 0x3f) == 0)
+                       nvkm_falcon_wr32(falcon, 0x188, tag++);
+               nvkm_falcon_wr32(falcon, 0x184, extra & (BIT(rem * 8) - 1));
+               ++i;
+       }
+
+       /* code must be padded to 0x40 words */
+       for (; i & 0x3f; i++)
+               nvkm_falcon_wr32(falcon, 0x184, 0);
+}
+
+static void
+nvkm_falcon_v1_load_dmem(struct nvkm_falcon *falcon, void *data, u32 start,
+                     u32 size, u8 port)
+{
+       u8 rem = size % 4;
+       int i;
+
+       size -= rem;
+
+       nvkm_falcon_wr32(falcon, 0x1c0 + (port * 16), start | (0x1 << 24));
+       for (i = 0; i < size / 4; i++)
+               nvkm_falcon_wr32(falcon, 0x1c4, ((u32 *)data)[i]);
+
+       /*
+        * If size is not a multiple of 4, mask the last work to ensure garbage
+        * does not get read
+        */
+       if (rem) {
+               u32 extra = ((u32 *)data)[i];
+
+               nvkm_falcon_wr32(falcon, 0x1c4, extra & (BIT(rem * 8) - 1));
+       }
+}
+
+static void
+nvkm_falcon_v1_read_dmem(struct nvkm_falcon *falcon, u32 start, u32 size,
+                        u8 port, void *data)
+{
+       u8 rem = size % 4;
+       int i;
+
+       size -= rem;
+
+       nvkm_falcon_wr32(falcon, 0x1c0 + (port * 16), start | (0x1 << 25));
+       for (i = 0; i < size / 4; i++)
+               ((u32 *)data)[i] = nvkm_falcon_rd32(falcon, 0x1c4);
+
+       /*
+        * If size is not a multiple of 4, mask the last work to ensure garbage
+        * does not get read
+        */
+       if (rem) {
+               u32 extra = nvkm_falcon_rd32(falcon, 0x1c4);
+
+               for (i = size; i < size + rem; i++) {
+                       ((u8 *)data)[i] = (u8)(extra & 0xff);
+                       extra >>= 8;
+               }
+       }
+}
+
+static void
+nvkm_falcon_v1_bind_context(struct nvkm_falcon *falcon, struct nvkm_gpuobj *ctx)
+{
+       u32 inst_loc;
+
+       /* disable instance block binding */
+       if (ctx == NULL) {
+               nvkm_falcon_wr32(falcon, 0x10c, 0x0);
+               return;
+       }
+
+       nvkm_falcon_wr32(falcon, 0x10c, 0x1);
+
+       /* setup apertures - virtual */
+       nvkm_falcon_wr32(falcon, 0xe00 + 4 * FALCON_DMAIDX_UCODE, 0x4);
+       nvkm_falcon_wr32(falcon, 0xe00 + 4 * FALCON_DMAIDX_VIRT, 0x0);
+       /* setup apertures - physical */
+       nvkm_falcon_wr32(falcon, 0xe00 + 4 * FALCON_DMAIDX_PHYS_VID, 0x4);
+       nvkm_falcon_wr32(falcon, 0xe00 + 4 * FALCON_DMAIDX_PHYS_SYS_COH, 0x5);
+       nvkm_falcon_wr32(falcon, 0xe00 + 4 * FALCON_DMAIDX_PHYS_SYS_NCOH, 0x6);
+
+       /* Set context */
+       if (nvkm_memory_target(ctx->memory) == NVKM_MEM_TARGET_VRAM)
+               inst_loc = 0x0; /* FB */
+       else
+               inst_loc = 0x3; /* Non-coherent sysmem */
+
+       /* Enable context */
+       nvkm_falcon_mask(falcon, 0x048, 0x1, 0x1);
+       nvkm_falcon_wr32(falcon, 0x480,
+                        ((ctx->addr >> 12) & 0xfffffff) |
+                        (inst_loc << 28) | (1 << 30));
+}
+
+static void
+nvkm_falcon_v1_set_start_addr(struct nvkm_falcon *falcon, u32 start_addr)
+{
+       nvkm_falcon_wr32(falcon, 0x104, start_addr);
+}
+
+static void
+nvkm_falcon_v1_start(struct nvkm_falcon *falcon)
+{
+       u32 reg = nvkm_falcon_rd32(falcon, 0x100);
+
+       if (reg & BIT(6))
+               nvkm_falcon_wr32(falcon, 0x130, 0x2);
+       else
+               nvkm_falcon_wr32(falcon, 0x100, 0x2);
+}
+
+static int
+nvkm_falcon_v1_wait_for_halt(struct nvkm_falcon *falcon, u32 ms)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       int ret;
+
+       ret = nvkm_wait_msec(device, ms, falcon->addr + 0x100, 0x10, 0x10);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int
+nvkm_falcon_v1_clear_interrupt(struct nvkm_falcon *falcon, u32 mask)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       int ret;
+
+       /* clear interrupt(s) */
+       nvkm_falcon_mask(falcon, 0x004, mask, mask);
+       /* wait until interrupts are cleared */
+       ret = nvkm_wait_msec(device, 10, falcon->addr + 0x008, mask, 0x0);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int
+falcon_v1_wait_idle(struct nvkm_falcon *falcon)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       int ret;
+
+       ret = nvkm_wait_msec(device, 10, falcon->addr + 0x04c, 0xffff, 0x0);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+
+static int
+nvkm_falcon_v1_enable(struct nvkm_falcon *falcon)
+{
+       struct nvkm_device *device = falcon->owner->device;
+       int ret;
+
+       ret = nvkm_wait_msec(device, 10, falcon->addr + 0x10c, 0x6, 0x0);
+       if (ret < 0) {
+               nvkm_error(falcon->user, "Falcon mem scrubbing timeout\n");
+               return ret;
+       }
+
+       ret = falcon_v1_wait_idle(falcon);
+       if (ret)
+               return ret;
+
+       /* enable IRQs */
+       nvkm_falcon_wr32(falcon, 0x010, 0xff);
+
+       return 0;
+}
+
+static void
+nvkm_falcon_v1_disable(struct nvkm_falcon *falcon)
+{
+       /* disable IRQs and wait for any previous code to complete */
+       nvkm_falcon_wr32(falcon, 0x014, 0xff);
+       falcon_v1_wait_idle(falcon);
+}
+
+static const struct nvkm_falcon_func
+nvkm_falcon_v1 = {
+       .load_imem = nvkm_falcon_v1_load_imem,
+       .load_dmem = nvkm_falcon_v1_load_dmem,
+       .read_dmem = nvkm_falcon_v1_read_dmem,
+       .bind_context = nvkm_falcon_v1_bind_context,
+       .start = nvkm_falcon_v1_start,
+       .wait_for_halt = nvkm_falcon_v1_wait_for_halt,
+       .clear_interrupt = nvkm_falcon_v1_clear_interrupt,
+       .enable = nvkm_falcon_v1_enable,
+       .disable = nvkm_falcon_v1_disable,
+       .set_start_addr = nvkm_falcon_v1_set_start_addr,
+};
+
+int
+nvkm_falcon_v1_new(struct nvkm_subdev *owner, const char *name, u32 addr,
+                  struct nvkm_falcon **pfalcon)
+{
+       struct nvkm_falcon *falcon;
+       if (!(falcon = *pfalcon = kzalloc(sizeof(*falcon), GFP_KERNEL)))
+               return -ENOMEM;
+       nvkm_falcon_ctor(&nvkm_falcon_v1, owner, name, addr, falcon);
+       return 0;
+}