staging: zcache: fix refcount leak

In zcache_get_pool_by_id, the refcount of zcache_host is not increased, but
it is always decreased in zcache_put_pool

Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/zcache/zcache-main.c b/drivers/staging/zcache/zcache-main.c
index c9e08bbeb519884ab63f9e557a313e438829aaf2..55fbe3db7d5342ea013852d31c4051426097c6ad 100644 (file)
--- a/drivers/staging/zcache/zcache-main.c
+++ b/drivers/staging/zcache/zcache-main.c
@@ -946,8 +946,9 @@ static struct tmem_pool *zcache_get_pool_by_id(uint16_t cli_id, uint16_t poolid)
                cli = &zcache_clients[cli_id];
                if (cli == NULL)
                        goto out;
-               atomic_inc(&cli->refcount);
        }
+
+       atomic_inc(&cli->refcount);
        pool = idr_find(&cli->tmem_pools, poolid);
        if (pool != NULL)
                atomic_inc(&pool->refcount);