ath9k: fix DMA stop sequence for AR9003+
authorFelix Fietkau <nbd@openwrt.org>
Tue, 2 Jun 2015 08:38:32 +0000 (10:38 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 8 Jun 2015 08:39:58 +0000 (11:39 +0300)
AR93xx and newer needs to stop rx before tx to avoid getting the DMA
engine or MAC into a stuck state.
This should reduce/fix the occurence of "Failed to stop Tx DMA" logspam.

Cc: stable@vger.kernel.org
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath9k/main.c

index d285e3a89853dc3cb9fa968caec77ca2b07f10b5..cfd45cb8ccfc13df856bb4bbe07d8e2bef21228f 100644 (file)
@@ -216,11 +216,13 @@ static bool ath_prepare_reset(struct ath_softc *sc)
        ath_stop_ani(sc);
        ath9k_hw_disable_interrupts(ah);
 
-       if (!ath_drain_all_txq(sc))
-               ret = false;
-
-       if (!ath_stoprecv(sc))
-               ret = false;
+       if (AR_SREV_9300_20_OR_LATER(ah)) {
+               ret &= ath_stoprecv(sc);
+               ret &= ath_drain_all_txq(sc);
+       } else {
+               ret &= ath_drain_all_txq(sc);
+               ret &= ath_stoprecv(sc);
+       }
 
        return ret;
 }