rtlwifi: rtl818x: silence uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 4 May 2016 06:16:39 +0000 (09:16 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 11 May 2016 18:51:45 +0000 (21:51 +0300)
What about if "rtlphy->pwrgroup_cnt" is 2?  In that case we would use an
uninitialized "chnlgroup" variable and probably crash.  Maybe that can't
happen for some reason which is not obvious but in that case this patch
is harmless.

Setting it to zero seems like a standard default in the surrounding code
so it's probably fine here as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/rtl8192se/rf.c

index 78a81c1e390bdd4052c64fd9cc4fe0a54b406aa8..9475aa2a8fa0aa55c19232dc569bf6735125f13e 100644 (file)
@@ -208,8 +208,7 @@ static void _rtl92s_get_txpower_writeval_byregulatory(struct ieee80211_hw *hw,
                                 "Realtek regulatory, 40MHz, writeval = 0x%x\n",
                                 writeval);
                } else {
-                       if (rtlphy->pwrgroup_cnt == 1)
-                               chnlgroup = 0;
+                       chnlgroup = 0;
 
                        if (rtlphy->pwrgroup_cnt >= 3) {
                                if (chnl <= 3)