skge: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Mirko Lindner <mlindner@marvell.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 06dffee81e02b4b321f63ee2ea67bbd6cb660dbf..0a2ec387a482f66df3ecd61ce3daba829a53a8bc 100644 (file)
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3731,7 +3731,6 @@ static int skge_device_event(struct notifier_block *unused,
 {
        struct net_device *dev = netdev_notifier_info_to_dev(ptr);
        struct skge_port *skge;
-       struct dentry *d;
 
        if (dev->netdev_ops->ndo_open != &skge_up || !skge_debug)
                goto done;
@@ -3739,33 +3738,20 @@ static int skge_device_event(struct notifier_block *unused,
        skge = netdev_priv(dev);
        switch (event) {
        case NETDEV_CHANGENAME:
-               if (skge->debugfs) {
-                       d = debugfs_rename(skge_debug, skge->debugfs,
-                                          skge_debug, dev->name);
-                       if (d)
-                               skge->debugfs = d;
-                       else {
-                               netdev_info(dev, "rename failed\n");
-                               debugfs_remove(skge->debugfs);
-                       }
-               }
+               if (skge->debugfs)
+                       skge->debugfs = debugfs_rename(skge_debug,
+                                                      skge->debugfs,
+                                                      skge_debug, dev->name);
                break;
 
        case NETDEV_GOING_DOWN:
-               if (skge->debugfs) {
-                       debugfs_remove(skge->debugfs);
-                       skge->debugfs = NULL;
-               }
+               debugfs_remove(skge->debugfs);
+               skge->debugfs = NULL;
                break;
 
        case NETDEV_UP:
-               d = debugfs_create_file(dev->name, 0444,
-                                       skge_debug, dev,
-                                       &skge_debug_fops);
-               if (!d || IS_ERR(d))
-                       netdev_info(dev, "debugfs create failed\n");
-               else
-                       skge->debugfs = d;
+               skge->debugfs = debugfs_create_file(dev->name, 0444, skge_debug,
+                                                   dev, &skge_debug_fops);
                break;
        }
 
@@ -3780,15 +3766,8 @@ static struct notifier_block skge_notifier = {
 
 static __init void skge_debug_init(void)
 {
-       struct dentry *ent;
-
-       ent = debugfs_create_dir("skge", NULL);
-       if (!ent || IS_ERR(ent)) {
-               pr_info("debugfs create directory failed\n");
-               return;
-       }
+       skge_debug = debugfs_create_dir("skge", NULL);
 
-       skge_debug = ent;
        register_netdevice_notifier(&skge_notifier);
 }