RDMA/cm: Abort loop in case of CM dequeue
authorLeon Romanovsky <leonro@mellanox.com>
Tue, 29 May 2018 11:56:16 +0000 (14:56 +0300)
committerDoug Ledford <dledford@redhat.com>
Fri, 1 Jun 2018 15:16:23 +0000 (11:16 -0400)
In case CM work list is empty, the work pointer will be NULL,
so instead of kernel crash it is better to abort processing
of works.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/cm.c

index 7df4c7173607ef1a09838a8f0807a3df9e0342d5..724f123c037f9a980fb5d1e469589af1a49ccd53 100644 (file)
@@ -1707,7 +1707,9 @@ static void cm_process_work(struct cm_id_private *cm_id_priv,
                spin_lock_irq(&cm_id_priv->lock);
                work = cm_dequeue_work(cm_id_priv);
                spin_unlock_irq(&cm_id_priv->lock);
-               BUG_ON(!work);
+               if (!work)
+                       return;
+
                ret = cm_id_priv->id.cm_handler(&cm_id_priv->id,
                                                &work->cm_event);
                cm_free_work(work);