perf thread: Introduce method to set comm from /proc/pid/self
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 26 Apr 2016 15:32:50 +0000 (12:32 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 26 Apr 2016 16:15:00 +0000 (13:15 -0300)
Will be used for lazy comm loading in 'perf trace'.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-7ogbkuoka1y2qsmcckqxvl5m@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/thread.c
tools/perf/util/thread.h

index de2036d1251b952dfccdfb46fc3578560822af96..45fcb715a36b3f6a975600d41eb877b387b78417 100644 (file)
@@ -10,6 +10,8 @@
 #include "comm.h"
 #include "unwind.h"
 
+#include <api/fs/fs.h>
+
 int thread__init_map_groups(struct thread *thread, struct machine *machine)
 {
        struct thread *leader;
@@ -153,6 +155,23 @@ int __thread__set_comm(struct thread *thread, const char *str, u64 timestamp,
        return 0;
 }
 
+int thread__set_comm_from_proc(struct thread *thread)
+{
+       char path[64];
+       char *comm = NULL;
+       size_t sz;
+       int err = -1;
+
+       if (!(snprintf(path, sizeof(path), "%d/task/%d/comm",
+                      thread->pid_, thread->tid) >= (int)sizeof(path)) &&
+           procfs__read_str(path, &comm, &sz) == 0) {
+               comm[sz - 1] = '\0';
+               err = thread__set_comm(thread, comm, 0);
+       }
+
+       return err;
+}
+
 const char *thread__comm_str(const struct thread *thread)
 {
        const struct comm *comm = thread__comm(thread);
index e214207bb13ac67df5a3c48bc379b1b65e583f75..45fba13c800bd36150248d4ade2b9f0b4b053329 100644 (file)
@@ -71,6 +71,8 @@ static inline int thread__set_comm(struct thread *thread, const char *comm,
        return __thread__set_comm(thread, comm, timestamp, false);
 }
 
+int thread__set_comm_from_proc(struct thread *thread);
+
 int thread__comm_len(struct thread *thread);
 struct comm *thread__comm(const struct thread *thread);
 struct comm *thread__exec_comm(const struct thread *thread);