platform: goldfish: pipe: Remove a redundant variable
authorRoman Kiryanov <rkir@google.com>
Mon, 27 Aug 2018 18:23:05 +0000 (11:23 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2018 13:31:30 +0000 (15:31 +0200)
The variable was not very useful.

Signed-off-by: Roman Kiryanov <rkir@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/platform/goldfish/goldfish_pipe.c

index 62422a4282f56b7ededa14d94e9b2986ed45b5ee..3d28a9be5722375ff6238a6644c8793d406fb071 100644 (file)
@@ -779,7 +779,6 @@ static struct miscdevice goldfish_pipe_miscdev = {
 static int goldfish_pipe_device_init(struct platform_device *pdev)
 {
        struct goldfish_pipe_dev *dev = &goldfish_pipe_dev;
-       char *page;
        int err = devm_request_irq(&pdev->dev, dev->irq,
                                goldfish_pipe_interrupt,
                                IRQF_SHARED, "goldfish_pipe", dev);
@@ -809,12 +808,12 @@ static int goldfish_pipe_device_init(struct platform_device *pdev)
         * is to just allocate a page and place the buffers in it.
         */
        BUILD_BUG_ON(sizeof(struct goldfish_pipe_dev_buffers) > PAGE_SIZE);
-       page = (char *)__get_free_page(GFP_KERNEL);
-       if (!page) {
+       dev->buffers = (struct goldfish_pipe_dev_buffers *)
+               __get_free_page(GFP_KERNEL);
+       if (!dev->buffers) {
                kfree(dev->pipes);
                return -ENOMEM;
        }
-       dev->buffers = (struct goldfish_pipe_dev_buffers *)page;
 
        /* Send the buffer addresses to the host */
        {