pinctrl: berlin: comment the spi functions
authorAntoine Tenart <antoine.tenart@free-electrons.com>
Tue, 2 Jun 2015 09:37:48 +0000 (11:37 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 10 Jun 2015 07:17:43 +0000 (09:17 +0200)
Add comments for the SPI functions, to distinguish CLK, SDI, SDO and
C{0,1,2,3}n.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/berlin/berlin-bg2.c
drivers/pinctrl/berlin/berlin-bg2cd.c
drivers/pinctrl/berlin/berlin-bg2q.c

index b71a6fffef1be35f8df1763e0abe81445130b929..b467e6e14f8a1d4b26e6816db9e4fad636bd7a6a 100644 (file)
 static const struct berlin_desc_group berlin2_soc_pinctrl_groups[] = {
        /* G */
        BERLIN_PINCTRL_GROUP("G0", 0x00, 0x1, 0x00,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* SS0n */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio")),
        BERLIN_PINCTRL_GROUP("G1", 0x00, 0x2, 0x01,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* SS1n */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio"),
                BERLIN_PINCTRL_FUNCTION(0x2, "usb1")),
        BERLIN_PINCTRL_GROUP("G2", 0x00, 0x2, 0x02,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"), /* SS2n */
                BERLIN_PINCTRL_FUNCTION(0x2, "pwm"),
                BERLIN_PINCTRL_FUNCTION(0x3, "i2s0")),
        BERLIN_PINCTRL_GROUP("G3", 0x00, 0x2, 0x04,
                BERLIN_PINCTRL_FUNCTION(0x0, "soc"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"), /* SS3n */
                BERLIN_PINCTRL_FUNCTION(0x2, "gpio"),
                BERLIN_PINCTRL_FUNCTION(0x3, "i2s1")),
        BERLIN_PINCTRL_GROUP("G4", 0x00, 0x2, 0x06,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* CLK/SDI/SDO */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio"),
                BERLIN_PINCTRL_FUNCTION(0x2, "pwm")),
        BERLIN_PINCTRL_GROUP("G5", 0x00, 0x3, 0x08,
@@ -163,15 +163,15 @@ static const struct berlin_desc_group berlin2_sysmgr_pinctrl_groups[] = {
        /* GSM */
        BERLIN_PINCTRL_GROUP("GSM0", 0x40, 0x2, 0x00,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* SS0n */
                BERLIN_PINCTRL_FUNCTION(0x2, "eth1")),
        BERLIN_PINCTRL_GROUP("GSM1", 0x40, 0x2, 0x02,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* SS1n */
                BERLIN_PINCTRL_FUNCTION(0x2, "eth1")),
        BERLIN_PINCTRL_GROUP("GSM2", 0x40, 0x2, 0x04,
                BERLIN_PINCTRL_FUNCTION(0x0, "twsi2"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi2")),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi2")), /* SS2n/SS3n */
        BERLIN_PINCTRL_GROUP("GSM3", 0x40, 0x2, 0x06,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
                BERLIN_PINCTRL_FUNCTION(0x1, "uart0"),  /* CTS/RTS */
@@ -187,7 +187,7 @@ static const struct berlin_desc_group berlin2_sysmgr_pinctrl_groups[] = {
                BERLIN_PINCTRL_FUNCTION(0x3, "twsi3")),
        BERLIN_PINCTRL_GROUP("GSM6", 0x40, 0x2, 0x0c,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* CLK/SDO */
                BERLIN_PINCTRL_FUNCTION(0x1, "clki")),
        BERLIN_PINCTRL_GROUP("GSM7", 0x40, 0x1, 0x0e,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
index 3fc05fb6ccf082234de5a1fd2dea85bf02d0832c..a8b98083a0311d52444fa8852bcf18181906959f 100644 (file)
@@ -68,17 +68,17 @@ static const struct berlin_desc_group berlin2cd_soc_pinctrl_groups[] = {
                BERLIN_PINCTRL_FUNCTION(0x1, "twsi1"),
                BERLIN_PINCTRL_FUNCTION(0x2, "gpio")),
        BERLIN_PINCTRL_GROUP("G8", 0x00, 0x3, 0x10,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* SS0n */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio")),
        BERLIN_PINCTRL_GROUP("G9", 0x00, 0x3, 0x13,
                BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x1, "spi1"), /* SS1n/SS2n */
                BERLIN_PINCTRL_FUNCTION(0x2, "twsi0")),
        BERLIN_PINCTRL_GROUP("G10", 0x00, 0x2, 0x16,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* CLK */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio")),
        BERLIN_PINCTRL_GROUP("G11", 0x00, 0x2, 0x18,
-               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+               BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* SDI/SDO */
                BERLIN_PINCTRL_FUNCTION(0x1, "gpio")),
        BERLIN_PINCTRL_GROUP("G12", 0x00, 0x3, 0x1a,
                BERLIN_PINCTRL_FUNCTION(0x0, "usb1"),
index bd9662e57ad3b653821882b9b4ff56ade237a9c3..65fb8711a42f768dcc150a28b26a95114f9ee0e6 100644 (file)
@@ -59,21 +59,21 @@ static const struct berlin_desc_group berlin2q_soc_pinctrl_groups[] = {
                        BERLIN_PINCTRL_FUNCTION(0x2, "gpio"),
                        BERLIN_PINCTRL_FUNCTION(0x3, "eddc")),
        BERLIN_PINCTRL_GROUP("G8", 0x18, 0x3, 0x18,
-                       BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+                       BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* CLK/SDI/SDO */
                        BERLIN_PINCTRL_FUNCTION(0x1, "gpio")),
        BERLIN_PINCTRL_GROUP("G9", 0x18, 0x3, 0x1b,
-                       BERLIN_PINCTRL_FUNCTION(0x0, "spi1"),
+                       BERLIN_PINCTRL_FUNCTION(0x0, "spi1"), /* SS0n/SS1n */
                        BERLIN_PINCTRL_FUNCTION(0x1, "gpio"),
                        BERLIN_PINCTRL_FUNCTION(0x5, "sata")),
        BERLIN_PINCTRL_GROUP("G10", 0x1c, 0x3, 0x00,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi1"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi1"), /* SS2n */
                        BERLIN_PINCTRL_FUNCTION(0x3, "i2s0"),
                        BERLIN_PINCTRL_FUNCTION(0x4, "pwm"),
                        BERLIN_PINCTRL_FUNCTION(0x5, "sata")),
        BERLIN_PINCTRL_GROUP("G11", 0x1c, 0x3, 0x03,
                        BERLIN_PINCTRL_FUNCTION(0x0, "jtag"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi1"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi1"), /* SS3n */
                        BERLIN_PINCTRL_FUNCTION(0x2, "gpio"),
                        BERLIN_PINCTRL_FUNCTION(0x3, "i2s1"),
                        BERLIN_PINCTRL_FUNCTION(0x4, "pwm"),
@@ -301,19 +301,19 @@ static const struct berlin_desc_group berlin2q_sysmgr_pinctrl_groups[] = {
        /* GSM */
        BERLIN_PINCTRL_GROUP("GSM0", 0x40, 0x2, 0x00,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* SS0n */
                        BERLIN_PINCTRL_FUNCTION(0x2, "eth1")),
        BERLIN_PINCTRL_GROUP("GSM1", 0x40, 0x2, 0x02,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* SS1n */
                        BERLIN_PINCTRL_FUNCTION(0x2, "eth1")),
        BERLIN_PINCTRL_GROUP("GSM2", 0x40, 0x2, 0x04,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* SS2n/SS3n */
                        BERLIN_PINCTRL_FUNCTION(0x2, "eddc")),
        BERLIN_PINCTRL_GROUP("GSM3", 0x40, 0x2, 0x06,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),
-                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"),
+                       BERLIN_PINCTRL_FUNCTION(0x1, "spi2"), /* CLK/SDO */
                        BERLIN_PINCTRL_FUNCTION(0x2, "eddc")),
        BERLIN_PINCTRL_GROUP("GSM4", 0x40, 0x1, 0x08,
                        BERLIN_PINCTRL_FUNCTION(0x0, "gpio"),