media: r820t: don't crash if attach fails
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Mar 2018 13:18:36 +0000 (09:18 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 09:36:20 +0000 (05:36 -0400)
As pointed by smatch:
drivers/media/tuners/r820t.c:2374 r820t_attach() error: potential null dereference 'priv'.  (kzalloc returns null)

The current function with prints error assumes that the attach
succeeds. So, don't use it in case of failures.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/tuners/r820t.c

index bc9299059f4830dc646726193393a32ba95d356d..3e14b9e2e763df20882c363ded7dfdfe19253b15 100644 (file)
@@ -20,6 +20,8 @@
 //
 //     RF Gain set/get is not implemented.
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/videodev2.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
@@ -2371,7 +2373,7 @@ err:
 err_no_gate:
        mutex_unlock(&r820t_list_mutex);
 
-       tuner_info("%s: failed=%d\n", __func__, rc);
+       pr_info("%s: failed=%d\n", __func__, rc);
        r820t_release(fe);
        return NULL;
 }