char: tpm: Deletion of unnecessary checks before the function call "tpm_dev_vendor_re...

The tpm_dev_vendor_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index 503a85ae176cdc74c14b5631a7c918f3fa62e0e3..5f448886417f5063177cf597519558db348bf4d3 100644 (file)
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -206,8 +206,7 @@ static int i2c_atmel_remove(struct i2c_client *client)
        struct device *dev = &(client->dev);
        struct tpm_chip *chip = dev_get_drvdata(dev);
 
-       if (chip)
-               tpm_dev_vendor_release(chip);
+       tpm_dev_vendor_release(chip);
        tpm_remove_hardware(dev);
        kfree(chip);
        return 0;

diff --git a/drivers/char/tpm/tpm_i2c_nuvoton.c b/drivers/char/tpm/tpm_i2c_nuvoton.c
index 23c7b137a7fdb47584b98429bc54f8e5c732d5dd..bbb4997438c3b4b6245b9d7072802703b6c4d0a1 100644 (file)
--- a/drivers/char/tpm/tpm_i2c_nuvoton.c
+++ b/drivers/char/tpm/tpm_i2c_nuvoton.c
@@ -630,8 +630,7 @@ static int i2c_nuvoton_remove(struct i2c_client *client)
        struct device *dev = &(client->dev);
        struct tpm_chip *chip = dev_get_drvdata(dev);
 
-       if (chip)
-               tpm_dev_vendor_release(chip);
+       tpm_dev_vendor_release(chip);
        tpm_remove_hardware(dev);
        kfree(chip);
        return 0;