mediatek: fit: fix use of uninitialized variable
authorQingfang Deng <qingfang.deng@siflower.com.cn>
Fri, 28 Jun 2024 09:01:00 +0000 (17:01 +0800)
committerChuanhong Guo <gch981213@gmail.com>
Sun, 7 Jul 2024 12:59:48 +0000 (20:59 +0800)
When building the kernel with -Wmaybe-uninitialized, GCC reports this
warning:

block/partitions/fit.c: In function 'parse_fit_partitions':
block/partitions/fit.c:164:3: warning: 'images' may be used uninitialized in this function [-Wmaybe-uninitialized]
  164 |   printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It appears to be a copy paste error. It's the "config" variable that is
supposed to be printed.

Fixes: e6aac8d98f56 ("image: add support for building FIT image with filesystem")
Signed-off-by: Qingfang Deng <qingfang.deng@siflower.com.cn>
target/linux/mediatek/files/block/partitions/fit.c

index 463cd4e9abae6abac3125c31141b3ad15e81612a..01b0f42c7c27cc953b11da96d3f99ea1a72af2f6 100644 (file)
@@ -161,7 +161,7 @@ int parse_fit_partitions(struct parsed_partitions *state, u64 fit_start_sector,
 
        config = fdt_path_offset(fit, FIT_CONFS_PATH);
        if (config < 0) {
-               printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, images);
+               printk(KERN_ERR "FIT: Cannot find %s node: %d\n", FIT_CONFS_PATH, config);
                ret = -ENOENT;
                goto ret_out;
        }