netfilter: ipt_ah: return boolean instead of integer
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Tue, 13 Feb 2018 14:25:57 +0000 (08:25 -0600)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 5 Mar 2018 22:15:43 +0000 (23:15 +0100)
Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv4/netfilter/ipt_ah.c

index a787d07f6cb757b741fcd600f9972c3399c95c85..7c6c20eaf4dbf04458cb861238c68f62763b2e9c 100644 (file)
@@ -47,7 +47,7 @@ static bool ah_mt(const struct sk_buff *skb, struct xt_action_param *par)
                 */
                pr_debug("Dropping evil AH tinygram.\n");
                par->hotdrop = true;
-               return 0;
+               return false;
        }
 
        return spi_match(ahinfo->spis[0], ahinfo->spis[1],