IB/ehca: Drop unnecessary NULL test

list_for_each_entry binds its first argument to a non-null value, and thus
any null test on the value of that argument is superfluous.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
iterator I;
expression x;
statement S,S1,S2;
@@

I(x,...) { <...
- if (x == NULL && ...) S
  ...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Alexander Schmidt <alexs@linux.vnet.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

diff --git a/drivers/infiniband/hw/ehca/ehca_mrmw.c b/drivers/infiniband/hw/ehca/ehca_mrmw.c
index 31a68b9c52d0c96f4739447f86918a5c4ed020fc..53f4cd4fc19a33d26da6e58d8fb0d4d5a41930e8 100644 (file)
--- a/drivers/infiniband/hw/ehca/ehca_mrmw.c
+++ b/drivers/infiniband/hw/ehca/ehca_mrmw.c
@@ -933,11 +933,6 @@ int ehca_unmap_fmr(struct list_head *fmr_list)
        /* check all FMR belong to same SHCA, and check internal flag */
        list_for_each_entry(ib_fmr, fmr_list, list) {
                prev_shca = shca;
-               if (!ib_fmr) {
-                       ehca_gen_err("bad fmr=%p in list", ib_fmr);
-                       ret = -EINVAL;
-                       goto unmap_fmr_exit0;
-               }
                shca = container_of(ib_fmr->device, struct ehca_shca,
                                    ib_device);
                e_fmr = container_of(ib_fmr, struct ehca_mr, ib.ib_fmr);