ACPI / video: Make logic a little easier to understand.
authorDanny Baumann <dannybaumann@web.de>
Tue, 19 Mar 2013 16:22:51 +0000 (16:22 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 24 Mar 2013 23:26:55 +0000 (00:26 +0100)
Make code paths a little easier to follow, and don't needlessly continue
list iteration.

Signed-off-by: Danny Baumann <dannybaumann@web.de>
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/video.c

index 387b3705279a4e743367310e6268e25446e5b125..8522d14972cf932020ac0dcb4c4da054b7a52f68 100644 (file)
@@ -745,16 +745,17 @@ acpi_video_init_brightness(struct acpi_video_device *device)
                 */
                if (use_bios_initial_backlight) {
                        for (i = 2; i < br->count; i++)
-                               if (level_old == br->levels[i])
+                               if (level_old == br->levels[i]) {
                                        level = level_old;
+                                       break;
+                               }
                }
-               goto set_level;
+       } else {
+               if (br->flags._BCL_reversed)
+                       level_old = (br->count - 1) - level_old;
+               level = br->levels[level_old];
        }
 
-       if (br->flags._BCL_reversed)
-               level_old = (br->count - 1) - level_old;
-       level = br->levels[level_old];
-
 set_level:
        result = acpi_video_device_lcd_set_level(device, level);
        if (result)