staging: unisys: visorbus: controlvm_respond add error handling
authorDavid Kershner <david.kershner@unisys.com>
Mon, 21 Nov 2016 17:15:46 +0000 (12:15 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Nov 2016 09:01:57 +0000 (10:01 +0100)
The function visorchanel_signalinsert now returns an error, propagate
the error up the stack to be handled.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 331f6b1929b87db5299db283edf7bfdc029bbd11..0c454f66beed3c94dcceb427e9f7241979465e02 100644 (file)
@@ -548,19 +548,17 @@ out_respond:
        return res;
 }
 
-static void
+static int
 controlvm_respond(struct controlvm_message_header *msg_hdr, int response)
 {
        struct controlvm_message outmsg;
 
        controlvm_init_response(&outmsg, msg_hdr, response);
        if (outmsg.hdr.flags.test_message == 1)
-               return;
+               return -EINVAL;
 
-       if (visorchannel_signalinsert(controlvm_channel,
-                                     CONTROLVM_QUEUE_REQUEST, &outmsg)) {
-               return;
-       }
+       return visorchannel_signalinsert(controlvm_channel,
+                                        CONTROLVM_QUEUE_REQUEST, &outmsg);
 }
 
 static void controlvm_respond_physdev_changestate(