cxgb3: AQ100X phy support update
authorDivy Le Ray <divy@chelsio.com>
Tue, 7 Jul 2009 19:48:48 +0000 (19:48 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Jul 2009 17:54:18 +0000 (10:54 -0700)
Add missing SUPPORTED_TP flag.
Update FW version checking.
Do the full initialization even if the FW version is unknown,
it might help catching further issues.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/cxgb3/aq100x.c

index b1fd5bf836e41cd8c50b95dd7c4d5e8d47f2f4c3..341b7ef1508f241d1ad358ed004a947877761846 100644 (file)
@@ -271,7 +271,8 @@ int t3_aq100x_phy_prep(struct cphy *phy, struct adapter *adapter, int phy_addr,
 
        cphy_init(phy, adapter, phy_addr, &aq100x_ops, mdio_ops,
                  SUPPORTED_1000baseT_Full | SUPPORTED_10000baseT_Full |
-                 SUPPORTED_Autoneg | SUPPORTED_AUI, "1000/10GBASE-T");
+                 SUPPORTED_TP | SUPPORTED_Autoneg | SUPPORTED_AUI,
+                 "1000/10GBASE-T");
 
        /*
         * The PHY has been out of reset ever since the system powered up.  So
@@ -316,11 +317,9 @@ int t3_aq100x_phy_prep(struct cphy *phy, struct adapter *adapter, int phy_addr,
 
        /* Firmware version check. */
        t3_mdio_read(phy, MDIO_MMD_VEND1, AQ_FW_VERSION, &v);
-       if (v != 30) {
+       if (v != 101)
                CH_WARN(adapter, "PHY%d: unsupported firmware %d\n",
                        phy_addr, v);
-               return 0; /* allow t3_prep_adapter to succeed */
-       }
 
        /*
         * The PHY should start in really-low-power mode.  Prepare it for normal