ext4: avoid panic during forced reboot due to aborted journal
authorJan Kara <jack@suse.cz>
Fri, 17 May 2019 21:37:18 +0000 (17:37 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 17 May 2019 21:37:18 +0000 (17:37 -0400)
Handling of aborted journal is a special code path different from
standard ext4_error() one and it can call panic() as well. Commit
1dc1097ff60e ("ext4: avoid panic during forced reboot") forgot to update
this path so fix that omission.

Fixes: 1dc1097ff60e ("ext4: avoid panic during forced reboot")
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 5.1
fs/ext4/super.c

index 5013d04b41fd05f4be8878772690ea837c5285bc..272e1881b5f822e534960fa63e3f0428faf64a7b 100644 (file)
@@ -699,7 +699,7 @@ void __ext4_abort(struct super_block *sb, const char *function,
                        jbd2_journal_abort(EXT4_SB(sb)->s_journal, -EIO);
                save_error_info(sb, function, line);
        }
-       if (test_opt(sb, ERRORS_PANIC)) {
+       if (test_opt(sb, ERRORS_PANIC) && !system_going_down()) {
                if (EXT4_SB(sb)->s_journal &&
                  !(EXT4_SB(sb)->s_journal->j_flags & JBD2_REC_ERR))
                        return;