usb: gadget: printer: use after free in gprinter_alloc_inst()

There was a missing goto so we free "opts" and then dereference it.

Fixes: ee1cd515e889 ('usb: gadget: printer: add configfs support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index caa56de3a3e865422c566bf5862550cf36d69fd1..48882ecf16106f0743fc587458fbe2794e035844 100644 (file)
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1307,6 +1307,7 @@ static struct usb_function_instance *gprinter_alloc_inst(void)
                kfree(opts);
                if (idr_is_empty(&printer_ida.idr))
                        gprinter_cleanup();
+               goto unlock;
        }
        config_group_init_type_name(&opts->func_inst.group, "",
                                    &printer_func_type);