staging: bcm2835-camera: remove anonymous field declarations
authorAishwarya Pant <aishpant@gmail.com>
Fri, 10 Mar 2017 16:39:27 +0000 (22:09 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 12 Mar 2017 14:16:51 +0000 (15:16 +0100)
Anonymous field declarations are error prone. This patch replaces
anonymous declarations with explicit field declarations for typedef
SERVICE_CREATION_T in vchiq_mmal_init(..)

Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

index 803095ee6c85cbd2b8d99aff840845ec35d6f320..88b379f52e0b26c956a196dd58b1bfa1709b77c6 100644 (file)
@@ -1977,16 +1977,16 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance)
        static VCHI_CONNECTION_T *vchi_connection;
        static VCHI_INSTANCE_T vchi_instance;
        SERVICE_CREATION_T params = {
-               VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),
-               VC_MMAL_SERVER_NAME,
-               vchi_connection,
-               0,              /* rx fifo size (unused) */
-               0,              /* tx fifo size (unused) */
-               service_callback,
-               NULL,           /* service callback parameter */
-               1,              /* unaligned bulk receives */
-               1,              /* unaligned bulk transmits */
-               0               /* want crc check on bulk transfers */
+               .version                = VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),
+               .service_id             = VC_MMAL_SERVER_NAME,
+               .connection             = vchi_connection,
+               .rx_fifo_size           = 0,
+               .tx_fifo_size           = 0,
+               .callback               = service_callback,
+               .callback_param         = NULL,
+               .want_unaligned_bulk_rx = 1,
+               .want_unaligned_bulk_tx = 1,
+               .want_crc               = 0
        };
 
        /* compile time checks to ensure structure size as they are