projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e5332d5
)
gpiolib: remove an unnecessary TODO
author
Bartosz Golaszewski
<brgl@bgdev.pl>
Mon, 16 Jul 2018 08:34:24 +0000
(10:34 +0200)
committer
Linus Walleij
<linus.walleij@linaro.org>
Mon, 16 Jul 2018 13:41:26 +0000
(15:41 +0200)
It's actually fine to read values of output lines. This was also
allowed by the legacy sysfs interface.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c
patch
|
blob
|
history
diff --git
a/drivers/gpio/gpiolib.c
b/drivers/gpio/gpiolib.c
index c507cd3d01c034563626ef805e1e54d0b13c2f44..464d5ba79f96691b706c8ac2dfa7b75f16c302ca 100644
(file)
--- a/
drivers/gpio/gpiolib.c
+++ b/
drivers/gpio/gpiolib.c
@@
-431,7
+431,7
@@
static long linehandle_ioctl(struct file *filep, unsigned int cmd,
int i;
if (cmd == GPIOHANDLE_GET_LINE_VALUES_IOCTL) {
- /*
TODO: check if descriptors are really input
*/
+ /*
NOTE: It's ok to read values of output lines.
*/
int ret = gpiod_get_array_value_complex(false,
true,
lh->numdescs,