projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cbf56c2
)
net/usb/drivers: Remove useless hrtimer_active check
author
Daniel Lezcano
<daniel.lezcano@linaro.org>
Tue, 19 Jun 2018 14:14:30 +0000
(16:14 +0200)
committer
David S. Miller
<davem@davemloft.net>
Wed, 20 Jun 2018 00:05:44 +0000
(09:05 +0900)
The code does:
if (hrtimer_active(&t))
hrtimer_cancel(&t);
However, hrtimer_cancel() checks if the timer is active, so the
test above is pointless.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/cdc_ncm.c
patch
|
blob
|
history
diff --git
a/drivers/net/usb/cdc_ncm.c
b/drivers/net/usb/cdc_ncm.c
index b0e8b9613054137215e2f502f9deeab3bbad8f80..1eaec648bd1f716db3d06622cdfb7834e64e4e38 100644
(file)
--- a/
drivers/net/usb/cdc_ncm.c
+++ b/
drivers/net/usb/cdc_ncm.c
@@
-967,8
+967,7
@@
void cdc_ncm_unbind(struct usbnet *dev, struct usb_interface *intf)
atomic_set(&ctx->stop, 1);
- if (hrtimer_active(&ctx->tx_timer))
- hrtimer_cancel(&ctx->tx_timer);
+ hrtimer_cancel(&ctx->tx_timer);
tasklet_kill(&ctx->bh);