GFS2: constify attribute_group structures.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Fri, 30 Jun 2017 13:33:54 +0000 (08:33 -0500)
committerBob Peterson <rpeterso@redhat.com>
Wed, 5 Jul 2017 12:21:14 +0000 (07:21 -0500)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
   5259    1344       8    6611    19d3 fs/gfs2/sys.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   5371    1216       8    6595    19c3 fs/gfs2/sys.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/sys.c

index 7a515345610c28dc4b35e8aa15f4b5061754c060..01dc027b47388e9e23017d8749c6769b257a1f16 100644 (file)
@@ -637,12 +637,12 @@ static struct attribute *tune_attrs[] = {
        NULL,
 };
 
-static struct attribute_group tune_group = {
+static const struct attribute_group tune_group = {
        .name = "tune",
        .attrs = tune_attrs,
 };
 
-static struct attribute_group lock_module_group = {
+static const struct attribute_group lock_module_group = {
        .name = "lock_module",
        .attrs = lock_module_attrs,
 };