sky2: not random enough
authorStephen Hemminger <shemminger@osdl.org>
Tue, 7 Mar 2006 19:06:35 +0000 (11:06 -0800)
committerFrancois Romieu <romieu@fr.zoreil.com>
Thu, 9 Mar 2006 22:19:01 +0000 (23:19 +0100)
Don't use sky2 to seed random pool beacause the network packet arrival time
will not be truly random due to NAPI and interrupt mitigation.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
drivers/net/sky2.c

index 72c1630977d6542696b8d4d7e05d146f92629fa8..dc4feaf79be2b4b165a7a76d28923046c6b843a2 100644 (file)
@@ -3243,8 +3243,7 @@ static int __devinit sky2_probe(struct pci_dev *pdev,
                }
        }
 
-       err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ | SA_SAMPLE_RANDOM,
-                         DRV_NAME, hw);
+       err = request_irq(pdev->irq, sky2_intr, SA_SHIRQ, DRV_NAME, hw);
        if (err) {
                printk(KERN_ERR PFX "%s: cannot assign irq %d\n",
                       pci_name(pdev), pdev->irq);