V4L/DVB (13800): [Mantis] I2C optimization. Required delay is much lesser than 1mS.
authorManu Abraham <abraham.manu@gmail.com>
Fri, 4 Dec 2009 12:02:00 +0000 (09:02 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 17 Jan 2010 13:55:43 +0000 (11:55 -0200)
Do not wait, keep looping instead.

Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/mantis/mantis_i2c.c

index 758f32a63b2f8983190d75757398663385115089..9d2b51d2e4b6593125e9728bcbb6a205b56c76c5 100644 (file)
@@ -58,7 +58,6 @@ static int mantis_i2c_read(struct mantis_pci *mantis, const struct i2c_msg *msg)
 
                /* wait for xfer completion */
                for (trials = 0; trials < TRIALS; trials++) {
-                       msleep(1);
                        stat = mmread(MANTIS_INT_STAT);
                        if (stat & MANTIS_INT_I2CDONE)
                                break;
@@ -71,7 +70,6 @@ static int mantis_i2c_read(struct mantis_pci *mantis, const struct i2c_msg *msg)
                        stat = mmread(MANTIS_INT_STAT);
                        if (stat & MANTIS_INT_I2CRACK)
                                break;
-                       msleep(1);
                }
 
                dprintk(MANTIS_TMG, 0, "I2CRACK: trials=%d\n", trials);
@@ -108,7 +106,6 @@ static int mantis_i2c_write(struct mantis_pci *mantis, const struct i2c_msg *msg
 
                /* wait for xfer completion */
                for (trials = 0; trials < TRIALS; trials++) {
-                       msleep(1);
                        stat = mmread(MANTIS_INT_STAT);
                        if (stat & MANTIS_INT_I2CDONE)
                                break;
@@ -121,7 +118,6 @@ static int mantis_i2c_write(struct mantis_pci *mantis, const struct i2c_msg *msg
                        stat = mmread(MANTIS_INT_STAT);
                        if (stat & MANTIS_INT_I2CRACK)
                                break;
-                       msleep(1);
                }
 
                dprintk(MANTIS_TMG, 0, "I2CRACK: trials=%d\n", trials);
@@ -164,7 +160,6 @@ static int mantis_i2c_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, in
                        mmwrite(txd, MANTIS_I2CDATA_CTL);
                        /* wait for xfer completion */
                        for (trials = 0; trials < TRIALS; trials++) {
-                               msleep(1);
                                stat = mmread(MANTIS_INT_STAT);
                                if (stat & MANTIS_INT_I2CDONE)
                                        break;