ipv6: icmp: use this_cpu_read() in icmpv6_sk()
authorEric Dumazet <edumazet@google.com>
Fri, 31 May 2019 22:27:00 +0000 (15:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Jun 2019 21:57:41 +0000 (14:57 -0700)
In general, this_cpu_read(*X) is faster than *this_cpu_ptr(X)

Also remove the inline attibute, totally useless.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/icmp.c

index afb915807cd0109e02df6e0858319c0ff78c33e8..d274f5b64afe0c5325d6f14c33842b7da61653e8 100644 (file)
@@ -79,9 +79,9 @@
  *
  *     On SMP we have one ICMP socket per-cpu.
  */
-static inline struct sock *icmpv6_sk(struct net *net)
+static struct sock *icmpv6_sk(struct net *net)
 {
-       return *this_cpu_ptr(net->ipv6.icmp_sk);
+       return this_cpu_read(*net->ipv6.icmp_sk);
 }
 
 static int icmpv6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,