nvme-fc: don't use bit masks for set/test_bit() numbers
authorJens Axboe <axboe@kernel.dk>
Fri, 24 Nov 2017 17:12:33 +0000 (10:12 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 24 Nov 2017 17:12:33 +0000 (10:12 -0700)
So far harmless, but it's confusing and a bug waiting to happen if the
shifts grow larger than 4.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/fc.c

index e0577bf33f45e62f8046c82645174e8610b5c23d..0a8af4daef8903f8ba983d345f1044498c57a975 100644 (file)
@@ -31,8 +31,8 @@
 
 
 enum nvme_fc_queue_flags {
-       NVME_FC_Q_CONNECTED = (1 << 0),
-       NVME_FC_Q_LIVE = (1 << 1),
+       NVME_FC_Q_CONNECTED = 0,
+       NVME_FC_Q_LIVE,
 };
 
 #define NVMEFC_QUEUE_DELAY     3               /* ms units */