staging: ks7010: refactor ks_wlan_set_beacon_lost function
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Wed, 25 Apr 2018 14:01:41 +0000 (16:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Apr 2018 07:17:34 +0000 (09:17 +0200)
Change if condition to handle invalid value first and
avoid nonsense else's path improving readability.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index aaa57c263002d5a7dd490be97034ffbdd57505aa..e2e72cd7e457de577bce5a06b17e435927e42599 100644 (file)
@@ -1973,17 +1973,17 @@ static int ks_wlan_set_beacon_lost(struct net_device *dev,
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
        /* for SLEEP MODE */
-       if (*uwrq >= BEACON_LOST_COUNT_MIN && *uwrq <= BEACON_LOST_COUNT_MAX)
-               priv->reg.beacon_lost_count = *uwrq;
-       else
+       if (*uwrq < BEACON_LOST_COUNT_MIN || *uwrq > BEACON_LOST_COUNT_MAX)
                return -EINVAL;
 
+       priv->reg.beacon_lost_count = *uwrq;
+
        if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
                priv->need_commit |= SME_MODE_SET;
                return -EINPROGRESS;    /* Call commit handler */
-       } else {
-               return 0;
        }
+
+       return 0;
 }
 
 static int ks_wlan_get_beacon_lost(struct net_device *dev,