drm/amd/display: set cp25201 to use TPS4
authorWenjing Liu <Wenjing.Liu@amd.com>
Thu, 14 Sep 2017 22:50:32 +0000 (18:50 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 21 Oct 2017 20:41:43 +0000 (16:41 -0400)
[Description]
hbr2 compliance eye output is unstable
(toggling on and off) with debugger break.
This caueses intermittent PHY automation failure.
Need to look into the root cause later

Signed-off-by: Wenjing Liu <Wenjing.Liu@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

index b735782b8fe025d9a16fec2465549442278509ad..ced42484dcfc7a45e51aec5ff1c69e823fe78ae9 100644 (file)
@@ -1700,6 +1700,12 @@ static void dp_test_send_link_training(struct dc_link *link)
        dp_retrain_link_dp_test(link, &link_settings, false);
 }
 
+/* TODO hbr2 compliance eye output is unstable
+ * (toggling on and off) with debugger break
+ * This caueses intermittent PHY automation failure
+ * Need to look into the root cause */
+static uint8_t force_tps4_for_cp2520 = 1;
+
 static void dp_test_send_phy_test_pattern(struct dc_link *link)
 {
        union phy_test_pattern dpcd_test_pattern;
@@ -1758,10 +1764,16 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link)
                test_pattern = DP_TEST_PATTERN_80BIT_CUSTOM;
                break;
        case PHY_TEST_PATTERN_CP2520_1:
-               test_pattern = DP_TEST_PATTERN_HBR2_COMPLIANCE_EYE;
+               /* CP2520 pattern is unstable, temporarily use TPS4 instead */
+               test_pattern = (force_tps4_for_cp2520 == 1) ?
+                               DP_TEST_PATTERN_TRAINING_PATTERN4 :
+                               DP_TEST_PATTERN_HBR2_COMPLIANCE_EYE;
                break;
        case PHY_TEST_PATTERN_CP2520_2:
-               test_pattern = DP_TEST_PATTERN_CP2520_2;
+               /* CP2520 pattern is unstable, temporarily use TPS4 instead */
+               test_pattern = (force_tps4_for_cp2520 == 1) ?
+                               DP_TEST_PATTERN_TRAINING_PATTERN4 :
+                               DP_TEST_PATTERN_HBR2_COMPLIANCE_EYE;
                break;
        case PHY_TEST_PATTERN_CP2520_3:
                test_pattern = DP_TEST_PATTERN_TRAINING_PATTERN4;