x86: fix AMDC1E and XTOPOLOGY conflict in cpufeature
authorVenki Pallipadi <venkatesh.pallipadi@intel.com>
Tue, 7 Oct 2008 20:33:12 +0000 (13:33 -0700)
committerIngo Molnar <mingo@elte.hu>
Fri, 31 Oct 2008 10:01:40 +0000 (11:01 +0100)
Impact: fix xsave slowdown regression

Fix two features from conflicting in feature bits.

Fixes this performance regression:

   Subject: cpu2000(both float and int) 13% regression with 2.6.28-rc1
   http://lkml.org/lkml/2008/10/28/36

Reported-by: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Bisected-by: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/cpufeature.h

index f73e95d75b45b48b360aaadf8a4c3d26b31b5b14..cfdf8c2c5c313a0de8639577cb12a3679292637c 100644 (file)
@@ -91,7 +91,7 @@
 #define X86_FEATURE_11AP       (3*32+19) /* "" Bad local APIC aka 11AP */
 #define X86_FEATURE_NOPL       (3*32+20) /* The NOPL (0F 1F) instructions */
 #define X86_FEATURE_AMDC1E     (3*32+21) /* AMD C1E detected */
-#define X86_FEATURE_XTOPOLOGY  (3*32+21) /* cpu topology enum extensions */
+#define X86_FEATURE_XTOPOLOGY  (3*32+22) /* cpu topology enum extensions */
 
 /* Intel-defined CPU features, CPUID level 0x00000001 (ecx), word 4 */
 #define X86_FEATURE_XMM3       (4*32+ 0) /* "pni" SSE-3 */