regulator: dbx500-prcmu: Remove unused fields from struct dbx500_regulator_info
authorAxel Lin <axel.lin@ingics.com>
Fri, 12 Apr 2019 01:54:21 +0000 (09:54 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 12 Apr 2019 08:51:10 +0000 (09:51 +0100)
The *dev is assigned but not used, remove it.
Current driver is using devm_regulator_register(), so no neeed to save
*rdev for clean up. Use a local variable instead.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/db8500-prcmu.c
drivers/regulator/dbx500-prcmu.h

index c2a3ccfc510e6d5c538deb4d80717aa88306a00e..eb317663f875382683745bc700d9b911702c88c5 100644 (file)
@@ -439,6 +439,7 @@ static int db8500_regulator_probe(struct platform_device *pdev)
        struct regulator_init_data *db8500_init_data;
        struct dbx500_regulator_info *info;
        struct regulator_config config = { };
+       struct regulator_dev *rdev;
        int err, i;
 
        db8500_init_data = dev_get_platdata(&pdev->dev);
@@ -446,17 +447,16 @@ static int db8500_regulator_probe(struct platform_device *pdev)
        for (i = 0; i < ARRAY_SIZE(dbx500_regulator_info); i++) {
                /* assign per-regulator data */
                info = &dbx500_regulator_info[i];
-               info->dev = &pdev->dev;
 
                config.driver_data = info;
                config.dev = &pdev->dev;
                if (db8500_init_data)
                        config.init_data = &db8500_init_data[i];
 
-               info->rdev = devm_regulator_register(&pdev->dev, &info->desc,
-                                                    &config);
-               if (IS_ERR(info->rdev)) {
-                       err = PTR_ERR(info->rdev);
+               rdev = devm_regulator_register(&pdev->dev, &info->desc,
+                                              &config);
+               if (IS_ERR(rdev)) {
+                       err = PTR_ERR(rdev);
                        dev_err(&pdev->dev, "failed to register %s: err %i\n",
                                info->desc.name, err);
                        return err;
index c8e51ace9f0619219f911377ff6177e6e0cac194..6e20dab611ac58413af9a7d8afcec61fa4d05b6e 100644 (file)
 
 /**
  * struct dbx500_regulator_info - dbx500 regulator information
- * @dev: device pointer
  * @desc: regulator description
- * @rdev: regulator device pointer
  * @is_enabled: status of the regulator
  * @epod_id: id for EPOD (power domain)
  * @is_ramret: RAM retention switch for EPOD (power domain)
  *
  */
 struct dbx500_regulator_info {
-       struct device *dev;
        struct regulator_desc desc;
-       struct regulator_dev *rdev;
        bool is_enabled;
        u16 epod_id;
        bool is_ramret;