net: qca_spi: convert to DEFINE_SHOW_ATTRIBUTE
authorYangtao Li <tiny.windzz@gmail.com>
Mon, 3 Dec 2018 14:26:38 +0000 (09:26 -0500)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Dec 2018 01:33:43 +0000 (17:33 -0800)
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/qca_debug.c

index 1450f386bc657557960b0e785cbc06a29a8e873a..bcb890b18a944d1ab7d47834993c7475943edf33 100644 (file)
@@ -126,19 +126,7 @@ qcaspi_info_show(struct seq_file *s, void *what)
 
        return 0;
 }
-
-static int
-qcaspi_info_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, qcaspi_info_show, inode->i_private);
-}
-
-static const struct file_operations qcaspi_info_ops = {
-       .open = qcaspi_info_open,
-       .read = seq_read,
-       .llseek = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(qcaspi_info);
 
 void
 qcaspi_init_device_debugfs(struct qcaspi *qca)
@@ -154,7 +142,7 @@ qcaspi_init_device_debugfs(struct qcaspi *qca)
                return;
        }
        debugfs_create_file("info", S_IFREG | 0444, device_root, qca,
-                           &qcaspi_info_ops);
+                           &qcaspi_info_fops);
 }
 
 void