ASoC: soc-component: add snd_soc_component_hw_params()

Current ALSA SoC is directly using component->driver->ops->xxx,
thus, it is deep nested, and makes code difficult to read,
and is not good for encapsulation.
This patch adds new snd_soc_component_hw_params() and use it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87blxh5rnf.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index ff8233014444ec474f5ccec031df914ece749e02..778a6e7d352dfedd217c3a4d489868c53a92e7f7 100644 (file)
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -345,5 +345,8 @@ int snd_soc_component_close(struct snd_soc_component *component,
                            struct snd_pcm_substream *substream);
 int snd_soc_component_prepare(struct snd_soc_component *component,
                              struct snd_pcm_substream *substream);
+int snd_soc_component_hw_params(struct snd_soc_component *component,
+                               struct snd_pcm_substream *substream,
+                               struct snd_pcm_hw_params *params);
 
 #endif /* __SOC_COMPONENT_H */

diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
index 733d7139d87535e84be701b6d2b836dfda87f7ea..7b6456370da5ace3b590dc06abc77f551aacfbad 100644 (file)
--- a/sound/soc/soc-component.c
+++ b/sound/soc/soc-component.c
@@ -315,3 +315,14 @@ int snd_soc_component_prepare(struct snd_soc_component *component,
 
        return 0;
 }
+
+int snd_soc_component_hw_params(struct snd_soc_component *component,
+                               struct snd_pcm_substream *substream,
+                               struct snd_pcm_hw_params *params)
+{
+       if (component->driver->ops &&
+           component->driver->ops->hw_params)
+               return component->driver->ops->hw_params(substream, params);
+
+       return 0;
+}

diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index c7fee67bc0dcb68fe6f37373ff172bbda6418fc8..8be1d22dc87a0f6e7543ec70e710643d0f9f62b4 100644 (file)
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -951,11 +951,7 @@ static int soc_pcm_hw_params(struct snd_pcm_substream *substream,
        for_each_rtdcom(rtd, rtdcom) {
                component = rtdcom->component;
 
-               if (!component->driver->ops ||
-                   !component->driver->ops->hw_params)
-                       continue;
-
-               ret = component->driver->ops->hw_params(substream, params);
+               ret = snd_soc_component_hw_params(component, substream, params);
                if (ret < 0) {
                        dev_err(component->dev,
                                "ASoC: %s hw params failed: %d\n",