clk: fix __clk_init_parent() for single parent clocks
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 9 Feb 2016 11:19:14 +0000 (20:19 +0900)
committerStephen Boyd <sboyd@codeaurora.org>
Tue, 9 Feb 2016 18:18:48 +0000 (10:18 -0800)
Before commit b3d192d5121f ("clk: simplify __clk_init_parent()"),
__clk_init_parent() called .get_parent() only for multi-parent
clocks.  That commit changed the behavior to call .get_parent()
if available even for single-parent clocks and root clocks.

It turned out a problem because there are some single-parent clocks
that implement .get_parent() callback and return non-zero index.
The SOCFPGA clock is the case; the commit broke the SOCFPGA boards.

To keep the original behavior, invoke .get_parent() only when
num_parents is greater than 1.

Fixes: b3d192d5121f ("clk: simplify __clk_init_parent()")
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reported-by: Dinh Nguyen <dinguyen@opensource.altera.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk.c

index cd8382c83f4897687fe599a398ac2e21d09db475..67cd2f116c3b8b34925caa6c21c02570ccaf872a 100644 (file)
@@ -1662,7 +1662,7 @@ static struct clk_core *__clk_init_parent(struct clk_core *core)
 {
        u8 index = 0;
 
-       if (core->ops->get_parent)
+       if (core->num_parents > 1 && core->ops->get_parent)
                index = core->ops->get_parent(core->hw);
 
        return clk_core_get_parent_by_index(core, index);