V4L/DVB: lgdt3305: re-write lgdt3304 ifbw hack in lgdt3305_rfagc_loop with FIXME
authorMichael Krufky <mkrufky@kernellabs.com>
Fri, 12 Mar 2010 03:00:55 +0000 (00:00 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 2 Aug 2010 17:46:29 +0000 (14:46 -0300)
Signed-off-by: Michael Krufky <mkrufky@kernellabs.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/frontends/lgdt3305.c

index 1c53766ac7387017a83e2711b7f69830fc0a8698..910cd785081df14cd6c6b8cbed9bea3e8fadeee1 100644 (file)
@@ -358,10 +358,12 @@ static int lgdt3305_rfagc_loop(struct lgdt3305_state *state,
        case QAM_256:
                agcdelay = 0x046b;
                rfbw     = 0x8889;
-               if (state->cfg->demod_chip == LGDT3305)
-                       ifbw = 0x8888;
-               else
+               /* FIXME: investigate optimal ifbw & rfbw values for the
+                *        DT3304 and re-write this switch..case block */
+               if (state->cfg->demod_chip == LGDT3304)
                        ifbw = 0x6666;
+               else /* (state->cfg->demod_chip == LGDT3305) */
+                       ifbw = 0x8888;
                break;
        default:
                return -EINVAL;