ixgbe: fix memory leaks
authorWenwen Wang <wenwen@cs.uga.edu>
Sun, 11 Aug 2019 20:07:47 +0000 (15:07 -0500)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 11 Sep 2019 16:10:45 +0000 (09:10 -0700)
In ixgbe_configure_clsu32(), 'jump', 'input', and 'mask' are allocated
through kzalloc() respectively in a for loop body. Then,
ixgbe_clsu32_build_input() is invoked to build the input. If this process
fails, next iteration of the for loop will be executed. However, the
allocated 'jump', 'input', and 'mask' are not deallocated on this execution
path, leading to memory leaks.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index 99df595abfbadeefd52f57003b46f069e538555e..95c0827dfd4ce281a498858f922f8af161ab804f 100644 (file)
@@ -9490,6 +9490,10 @@ static int ixgbe_configure_clsu32(struct ixgbe_adapter *adapter,
                                jump->mat = nexthdr[i].jump;
                                adapter->jump_tables[link_uhtid] = jump;
                                break;
+                       } else {
+                               kfree(mask);
+                               kfree(input);
+                               kfree(jump);
                        }
                }
                return 0;