mtd: nand: denali: propagate page to helpers via function argument

This driver stores the currently addressed page into denali->page,
which is later read out by helper functions.  While I am tackling on
this driver, I often missed to insert "denali->page = page;" where
needed.  This makes page_read/write callbacks to get access to a
wrong page, which is a bug hard to figure out.

Instead, I'd rather pass the page via function argument because the
compiler's prototype checks will help to detect bugs.

For the same reason, propagate dma_addr to the DMA helpers instead
of denali->buf.dma_buf .

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index 31d987d26e1293a9575b481a6edaa12f09801730..24849f6bb37b3596f78124e826e06c464579d2a5 100644 (file)
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -337,7 +337,7 @@ static int denali_dev_ready(struct mtd_info *mtd)
  * sends a pipeline command operation to the controller. See the Denali NAND
  * controller's user guide for more information (section 4.2.3.6).
  */
-static int denali_send_pipeline_cmd(struct denali_nand_info *denali,
+static int denali_send_pipeline_cmd(struct denali_nand_info *denali, int page,
                                    bool ecc_en, bool transfer_spare,
                                    int access_type, int op)
 {
@@ -348,7 +348,7 @@ static int denali_send_pipeline_cmd(struct denali_nand_info *denali,
 
        denali_reset_irq(denali);
 
-       addr = BANK(denali->flash_bank) | denali->page;
+       addr = BANK(denali->flash_bank) | page;
 
        if (op == DENALI_WRITE && access_type != SPARE_ACCESS) {
                cmd = MODE_01 | addr;
@@ -421,9 +421,7 @@ static int write_oob_data(struct mtd_info *mtd, uint8_t *buf, int page)
        uint32_t irq_mask = INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL;
        int status = 0;
 
-       denali->page = page;
-
-       if (denali_send_pipeline_cmd(denali, false, false, SPARE_ACCESS,
+       if (denali_send_pipeline_cmd(denali, page, false, false, SPARE_ACCESS,
                                                        DENALI_WRITE) == PASS) {
                write_data_to_flash_mem(denali, buf, mtd->oobsize);
 
@@ -448,9 +446,7 @@ static void read_oob_data(struct mtd_info *mtd, uint8_t *buf, int page)
        uint32_t irq_mask = INTR__LOAD_COMP;
        uint32_t irq_status, addr, cmd;
 
-       denali->page = page;
-
-       if (denali_send_pipeline_cmd(denali, false, true, SPARE_ACCESS,
+       if (denali_send_pipeline_cmd(denali, page, false, true, SPARE_ACCESS,
                                                        DENALI_READ) == PASS) {
                read_data_from_flash_mem(denali, buf, mtd->oobsize);
 
@@ -462,8 +458,7 @@ static void read_oob_data(struct mtd_info *mtd, uint8_t *buf, int page)
                irq_status = denali_wait_for_irq(denali, irq_mask);
 
                if (!(irq_status & INTR__LOAD_COMP))
-                       dev_err(denali->dev, "page on OOB timeout %d\n",
-                                       denali->page);
+                       dev_err(denali->dev, "page on OOB timeout %d\n", page);
 
                /*
                 * We set the device back to MAIN_ACCESS here as I observed
@@ -472,7 +467,7 @@ static void read_oob_data(struct mtd_info *mtd, uint8_t *buf, int page)
                 * is reliable (according to the MTD test infrastructure)
                 * if you are in MAIN_ACCESS.
                 */
-               addr = BANK(denali->flash_bank) | denali->page;
+               addr = BANK(denali->flash_bank) | page;
                cmd = MODE_10 | addr;
                index_addr(denali, cmd, MAIN_ACCESS);
        }
@@ -637,13 +632,13 @@ static void denali_enable_dma(struct denali_nand_info *denali, bool en)
        ioread32(denali->flash_reg + DMA_ENABLE);
 }
 
-static void denali_setup_dma64(struct denali_nand_info *denali, int op)
+static void denali_setup_dma64(struct denali_nand_info *denali,
+                              dma_addr_t dma_addr, int page, int op)
 {
        uint32_t mode;
        const int page_count = 1;
-       uint64_t addr = denali->buf.dma_buf;
 
-       mode = MODE_10 | BANK(denali->flash_bank) | denali->page;
+       mode = MODE_10 | BANK(denali->flash_bank) | page;
 
        /* DMA is a three step process */
 
@@ -654,41 +649,42 @@ static void denali_setup_dma64(struct denali_nand_info *denali, int op)
        index_addr(denali, mode, 0x01002000 | (64 << 16) | op | page_count);
 
        /* 2. set memory low address */
-       index_addr(denali, mode, addr);
+       index_addr(denali, mode, dma_addr);
 
        /* 3. set memory high address */
-       index_addr(denali, mode, addr >> 32);
+       index_addr(denali, mode, (uint64_t)dma_addr >> 32);
 }
 
-static void denali_setup_dma32(struct denali_nand_info *denali, int op)
+static void denali_setup_dma32(struct denali_nand_info *denali,
+                              dma_addr_t dma_addr, int page, int op)
 {
        uint32_t mode;
        const int page_count = 1;
-       uint32_t addr = denali->buf.dma_buf;
 
        mode = MODE_10 | BANK(denali->flash_bank);
 
        /* DMA is a four step process */
 
        /* 1. setup transfer type and # of pages */
-       index_addr(denali, mode | denali->page, 0x2000 | op | page_count);
+       index_addr(denali, mode | page, 0x2000 | op | page_count);
 
        /* 2. set memory high address bits 23:8 */
-       index_addr(denali, mode | ((addr >> 16) << 8), 0x2200);
+       index_addr(denali, mode | ((dma_addr >> 16) << 8), 0x2200);
 
        /* 3. set memory low address bits 23:8 */
-       index_addr(denali, mode | ((addr & 0xffff) << 8), 0x2300);
+       index_addr(denali, mode | ((dma_addr & 0xffff) << 8), 0x2300);
 
        /* 4. interrupt when complete, burst len = 64 bytes */
        index_addr(denali, mode | 0x14000, 0x2400);
 }
 
-static void denali_setup_dma(struct denali_nand_info *denali, int op)
+static void denali_setup_dma(struct denali_nand_info *denali,
+                            dma_addr_t dma_addr, int page, int op)
 {
        if (denali->caps & DENALI_CAP_DMA_64BIT)
-               denali_setup_dma64(denali, op);
+               denali_setup_dma64(denali, dma_addr, page, op);
        else
-               denali_setup_dma32(denali, op);
+               denali_setup_dma32(denali, dma_addr, page, op);
 }
 
 /*
@@ -705,8 +701,6 @@ static int write_page(struct mtd_info *mtd, struct nand_chip *chip,
        uint32_t irq_mask = INTR__DMA_CMD_COMP | INTR__PROGRAM_FAIL;
        int ret = 0;
 
-       denali->page = page;
-
        /*
         * if it is a raw xfer, we want to disable ecc and send the spare area.
         * !raw_xfer - enable ecc
@@ -729,7 +723,7 @@ static int write_page(struct mtd_info *mtd, struct nand_chip *chip,
        denali_reset_irq(denali);
        denali_enable_dma(denali, true);
 
-       denali_setup_dma(denali, DENALI_WRITE);
+       denali_setup_dma(denali, addr, page, DENALI_WRITE);
 
        /* wait for operation to complete */
        irq_status = denali_wait_for_irq(denali, irq_mask);
@@ -805,15 +799,13 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip,
        unsigned long uncor_ecc_flags = 0;
        int stat = 0;
 
-       denali->page = page;
-
        setup_ecc_for_xfer(denali, true, false);
 
        denali_enable_dma(denali, true);
        dma_sync_single_for_device(denali->dev, addr, size, DMA_FROM_DEVICE);
 
        denali_reset_irq(denali);
-       denali_setup_dma(denali, DENALI_READ);
+       denali_setup_dma(denali, addr, page, DENALI_READ);
 
        /* wait for operation to complete */
        irq_status = denali_wait_for_irq(denali, irq_mask);
@@ -832,7 +824,7 @@ static int denali_read_page(struct mtd_info *mtd, struct nand_chip *chip,
                return stat;
 
        if (uncor_ecc_flags) {
-               read_oob_data(mtd, chip->oob_poi, denali->page);
+               read_oob_data(mtd, chip->oob_poi, page);
 
                stat = denali_check_erased_page(mtd, chip, buf,
                                                uncor_ecc_flags, stat);
@@ -850,15 +842,13 @@ static int denali_read_page_raw(struct mtd_info *mtd, struct nand_chip *chip,
        uint32_t irq_mask = INTR__DMA_CMD_COMP;
        uint32_t irq_status;
 
-       denali->page = page;
-
        setup_ecc_for_xfer(denali, false, true);
        denali_enable_dma(denali, true);
 
        dma_sync_single_for_device(denali->dev, addr, size, DMA_FROM_DEVICE);
 
        denali_reset_irq(denali);
-       denali_setup_dma(denali, DENALI_READ);
+       denali_setup_dma(denali, addr, page, DENALI_READ);
 
        /* wait for operation to complete */
        irq_status = denali_wait_for_irq(denali, irq_mask);

diff --git a/drivers/mtd/nand/denali.h b/drivers/mtd/nand/denali.h
index a84d8784ee9872acf4a91add64dd10fac711b499..ad2223d179d070402f41dc9574427e46d4579534 100644 (file)
--- a/drivers/mtd/nand/denali.h
+++ b/drivers/mtd/nand/denali.h
@@ -316,7 +316,6 @@ struct denali_nand_info {
        int flash_bank; /* currently selected chip */
        struct nand_buf buf;
        struct device *dev;
-       int page;
        void __iomem *flash_reg;        /* Register Interface */
        void __iomem *flash_mem;        /* Host Data/Command Interface */