netfilter: nft_quota: introduce nft_overquota()

This is patch renames the existing function to nft_overquota() and make
it return a boolean that tells us if we have exceeded our byte quota.
Just a cleanup.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/net/netfilter/nft_quota.c b/net/netfilter/nft_quota.c
index 92b6ff16dbb387510d61ee9c0bec8291ea49e016..c00104c070958b8b3835274b8b99215828bdd126 100644 (file)
--- a/net/netfilter/nft_quota.c
+++ b/net/netfilter/nft_quota.c
@@ -21,10 +21,10 @@ struct nft_quota {
        atomic64_t      remain;
 };
 
-static inline long nft_quota(struct nft_quota *priv,
-                            const struct nft_pktinfo *pkt)
+static inline bool nft_overquota(struct nft_quota *priv,
+                                const struct nft_pktinfo *pkt)
 {
-       return atomic64_sub_return(pkt->skb->len, &priv->remain);
+       return atomic64_sub_return(pkt->skb->len, &priv->remain) < 0;
 }
 
 static void nft_quota_eval(const struct nft_expr *expr,
@@ -33,7 +33,7 @@ static void nft_quota_eval(const struct nft_expr *expr,
 {
        struct nft_quota *priv = nft_expr_priv(expr);
 
-       if ((nft_quota(priv, pkt) < 0) ^ priv->invert)
+       if (nft_overquota(priv, pkt) ^ priv->invert)
                regs->verdict.code = NFT_BREAK;
 }