IB/srp: Simplify SCSI error handling
authorBart Van Assche <bvanassche@acm.org>
Wed, 24 Oct 2012 13:05:37 +0000 (15:05 +0200)
committerRoland Dreier <roland@purestorage.com>
Sat, 1 Dec 2012 01:40:30 +0000 (17:40 -0800)
Since scsi_remove_host() has been modified so that SCSI error handling
functions will no longer be invoked after scsi_remove_host() returns,
the test at the start of srp_send_tsk_mgmt() is now superfluous.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: David Dillow <dillowda@ornl.gov>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/ulp/srp/ib_srp.c

index 9371d582d0dcb0dcf471db447c8bb06735c4cd00..baafee085e3375a9d6bcc38a50f2b51a6034ac3e 100644 (file)
@@ -1661,10 +1661,6 @@ static int srp_send_tsk_mgmt(struct srp_target_port *target,
        struct srp_iu *iu;
        struct srp_tsk_mgmt *tsk_mgmt;
 
-       if (target->state == SRP_TARGET_DEAD ||
-           target->state == SRP_TARGET_REMOVED)
-               return -1;
-
        init_completion(&target->tsk_mgmt_done);
 
        spin_lock_irq(&target->lock);