luci-app-dawn: fix crash issue when viewing hearing map
authorBCoverstone <brian@mainsequence.net>
Tue, 10 Jan 2023 03:28:28 +0000 (22:28 -0500)
committerJo-Philipp Wich <jo@mein.io>
Wed, 15 Mar 2023 13:26:59 +0000 (14:26 +0100)
When viewing the hearing map, sometimes a crash will happen when one of the
routers suddenly cannot view a client. This PR simply checks that the radio
frequency in data2 is not 0, and skips the entry if it is a 0.

Submitted-by: Brian Coverstone <brian@mainsequence.net>
[fix commit subject, add commit description]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
applications/luci-app-dawn/luasrc/model/cbi/dawn/dawn_hearing_map.lua

index d2778655035472748925b72672b3a8b19e5c40fa..3ba5329855008a3b393d9ea5942f51f2262867b5 100644 (file)
@@ -38,6 +38,7 @@ function s.render(self, sid)
                                                        local mac2, data2
                                                        local count_loop = 0
                                                        for mac2, data2 in pairs(data) do
+                                                               if data2.freq ~= 0 then --prevent empty entry crashes
                                        %>
                                                <tr class="tr">
                                                        <td class="td"><%= (count_loop == 0) and mac or "" %></td>
@@ -53,7 +54,8 @@ function s.render(self, sid)
                                                        <td class="td"><%= "%d" % data2.score %></td>
                                                </tr>
                                        <%
-                                                               count_loop = count_loop + 1
+                                                                       count_loop = count_loop + 1
+                                                               end
                                                        end
                                                end
                                        %>