pie: remove unnecessary type casting
authorLeslie Monis <lesliemonis@gmail.com>
Wed, 4 Mar 2020 18:56:00 +0000 (00:26 +0530)
committerDavid S. Miller <davem@davemloft.net>
Wed, 4 Mar 2020 21:25:55 +0000 (13:25 -0800)
In function pie_calculate_probability(), the variables alpha and
beta are of type u64. The variables qdelay, qdelay_old and
params->target are of type psched_time_t (which is also u64).
The explicit type casting done when calculating the value for
the variable delta is redundant and not required.

Signed-off-by: Mohit P. Tahiliani <tahiliani@nitk.edu.in>
Signed-off-by: Gautam Ramakrishnan <gautamramk@gmail.com>
Signed-off-by: Leslie Monis <lesliemonis@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_pie.c

index 8a2f9f11c86fa00120b959586a1f91499ecb7434..198cfa34a00a9baced431e8d99071c69bab3e188 100644 (file)
@@ -363,8 +363,8 @@ void pie_calculate_probability(struct pie_params *params, struct pie_vars *vars,
        }
 
        /* alpha and beta should be between 0 and 32, in multiples of 1/16 */
-       delta += alpha * (u64)(qdelay - params->target);
-       delta += beta * (u64)(qdelay - qdelay_old);
+       delta += alpha * (qdelay - params->target);
+       delta += beta * (qdelay - qdelay_old);
 
        oldprob = vars->prob;