xen: provide a prototype for xen_biovec_phys_mergeable in xen.h
authorChristoph Hellwig <hch@lst.de>
Tue, 25 Sep 2018 20:30:07 +0000 (13:30 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 26 Sep 2018 14:45:10 +0000 (08:45 -0600)
Having multiple externs in arch headers is not a good way to provide
a common interface.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
arch/arm/include/asm/io.h
arch/arm64/include/asm/io.h
arch/x86/include/asm/io.h
include/xen/xen.h

index e58ca25eddb74f8dda2f0af7d0efdbd44d27e7c9..cf5cd88e72890933692541ce90a210d9e40d977c 100644 (file)
@@ -459,9 +459,6 @@ extern void pci_iounmap(struct pci_dev *dev, void __iomem *addr);
 
 #include <asm-generic/io.h>
 
-struct bio_vec;
-extern bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
-                                     const struct bio_vec *vec2);
 #define ARCH_BIOVEC_PHYS_MERGEABLE(vec1, vec2)                         \
         (!xen_domain() || xen_biovec_phys_mergeable(vec1, vec2))
 
index 774e03ea1bb0ac4f8c87ed171a54a05fcdcd1d0b..06119ee511cda33f2cf38141f4190b672f85aa6f 100644 (file)
@@ -205,9 +205,6 @@ extern int valid_mmap_phys_addr_range(unsigned long pfn, size_t size);
 
 extern int devmem_is_allowed(unsigned long pfn);
 
-struct bio_vec;
-extern bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
-                                     const struct bio_vec *vec2);
 #define ARCH_BIOVEC_PHYS_MERGEABLE(vec1, vec2)                         \
         (!xen_domain() || xen_biovec_phys_mergeable(vec1, vec2))
 
index 7c6106216d9c96d941b98386563c85a561e254ae..abdb501a551d7b63782e99563291eafa39383b3b 100644 (file)
@@ -371,10 +371,6 @@ extern bool is_early_ioremap_ptep(pte_t *ptep);
 
 #ifdef CONFIG_XEN
 #include <xen/xen.h>
-struct bio_vec;
-
-extern bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
-                                     const struct bio_vec *vec2);
 
 #define ARCH_BIOVEC_PHYS_MERGEABLE(vec1, vec2)                         \
         (!xen_domain() || xen_biovec_phys_mergeable(vec1, vec2))
index 1e1d9bd0bd3788711d8722e7ec9e1a15661d7c3b..d7a2678da77fb808bf8c6015e1bf19b7256db8a1 100644 (file)
@@ -39,4 +39,8 @@ extern uint32_t xen_start_flags;
 #define xen_initial_domain()   (0)
 #endif /* CONFIG_XEN_DOM0 */
 
+struct bio_vec;
+bool xen_biovec_phys_mergeable(const struct bio_vec *vec1,
+               const struct bio_vec *vec2);
+
 #endif /* _XEN_XEN_H */